Closed
Bug 1426050
Opened 6 years ago
Closed 6 years ago
Update default value of timeline parameter to Animation constructor
Categories
(Core :: DOM: Animation, enhancement, P3)
Core
DOM: Animation
Tracking
()
RESOLVED
INVALID
Tracking | Status | |
---|---|---|
firefox59 | --- | affected |
People
(Reporter: birtles, Assigned: birtles)
Details
(Keywords: dev-doc-needed)
Attachments
(1 file)
This bug tracks the following spec change: https://github.com/w3c/csswg-drafts/commit/d354480fb37ffa4cd7a72e26e0b4ab2ff17cbcd2 Rationale: https://github.com/w3c/csswg-drafts/issues/2078 WIP patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b92a727bec4c6f6a5e35e235f6deecab33d656e
Assignee | ||
Updated•6 years ago
|
Keywords: dev-doc-needed
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8937642 [details] Bug 1426050 - Add default null value for timeline parameter to Animation constructor; https://reviewboard.mozilla.org/r/208324/#review214246 ::: commit-message-7c457:6 (Diff revision 1) > +Bug 1426050 - Add default null value for timeline parameter to Animation constructor; r?bz > + > +This changeset reflects the following change to the Web Animations > +specification: > + > + https://github.com/w3c/csswg-drafts/commit/d354480fb37ffa4cd7a72e26e0b4ab2ff17cbcd2 This is OK if you really want this change, but note that the premises the change was based on are slightly faulty. See https://github.com/w3c/csswg-drafts/issues/2078#issuecomment-352833722 for details.
Attachment #8937642 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•6 years ago
|
||
Yes, you're right. I just assumed Antoine was right that `new Animation(null, undefined)` and `new Animation(null)` behave differently but now I see that they don't. I'll wait to see what Antoine says and possibly revert the spec change (and replace "not provided" with "missing").
Assignee | ||
Comment 4•6 years ago
|
||
Decided not to go ahead with this change based on bz's feedback. I've reverted the spec change.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•