Closed
Bug 1426065
Opened 6 years ago
Closed 6 years ago
Move ShapeInfo and its dervied classes from header to cpp
Categories
(Core :: Layout: Floats, enhancement, P3)
Core
Layout: Floats
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(2 files)
ShapInfo and its derived classes are private to nsFloatManager, which doesn't need to be in the header. Move them to cpp to make compile faster after changing them.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8937656 [details] Bug 1426065 Part 1 - Move ShapeInfo and its dervied classes from header to cpp. https://reviewboard.mozilla.org/r/208362/#review214258
Attachment #8937656 -
Flags: review?(dholbert) → review+
|
|
||
Comment 4•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8937657 [details] Bug 1426065 Part 2 - Drop mozilla prefix in nsFloatManager.cpp. https://reviewboard.mozilla.org/r/208364/#review214260
Attachment #8937657 -
Flags: review?(dholbert) → review+
Pushed by tlin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/974d0af75f21 Part 1 - Move ShapeInfo and its dervied classes from header to cpp. r=dholbert https://hg.mozilla.org/integration/autoland/rev/127567f2455b Part 2 - Drop mozilla prefix in nsFloatManager.cpp. r=dholbert
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/974d0af75f21 https://hg.mozilla.org/mozilla-central/rev/127567f2455b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•