Closed Bug 1426117 Opened 2 years ago Closed 2 years ago

Failure when opening a bug: Invalid parameter passed to Bugzilla::Bug::new_from_list: It must be numeric.

Categories

(bugzilla.mozilla.org :: General, defect)

Production
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: whimboo, Assigned: dylan)

References

Details

Attachments

(1 file)

PR
45 bytes, text/x-github-pull-request
Details | Review
I tried to open the following link and got a failure:

https://bugzilla.mozilla.org/show_bug.cgi?id=1388018#c42

`Invalid parameter passed to Bugzilla::Bug::new_from_list: It must be numeric.`
This change has been rolled back and we're investigating what happened.
Btw. it was also happening without a hash.
Summary: Failure when opening a bug with hash: Invalid parameter passed to Bugzilla::Bug::new_from_list: It must be numeric. → Failure when opening a bug: Invalid parameter passed to Bugzilla::Bug::new_from_list: It must be numeric.
Note that this bug also exhibits the behavior. Here is the stack trace:

at /data/www/bugzilla.mozilla.org/Bugzilla/Object.pm line 171.
	Bugzilla::Object::new_from_list(...) called at /data/www/bugzilla.mozilla.org/Bugzilla/Bug.pm line 745
	Bugzilla::Bug::_preload_referenced_bugs(...) called at /data/www/bugzilla.mozilla.org/Bugzilla/Bug.pm line 709
	Bugzilla::Bug::preload(...) called at /data/www/bugzilla.mozilla.org/show_bug.cgi line 103
	ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::data_www_bugzilla_2emozilla_2eorg_show_bug_2ecgi::handler(...) called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 204
	eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 204
	ModPerl::RegistryCooker::run(...) called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 170
	ModPerl::RegistryCooker::default_handler(...) called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 31
	ModPerl::Registry::handler(...) called at /data/www/bugzilla.mozilla.org/mod_perl.pl line 145
	Bugzilla::ModPerl::ResponseHandler::handler(...) called at -e line 0
	eval {...} called at -e line 0
The problem happens on all bugs that link to an existing bug using the urlbase of the site. It smells like the urlbase patch broke the comment formatting code slightly.
Assignee: nobody → dylan
Depends on: 1403777
Attached file PR
Working on a test case and then a fix.
A dumb error in a regexp (a capture group was removed). There's a test case for this now -- and a place where we can add other tests against the formatting system.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.