1426206 - DAMP tests don't allow waterfall to render

Status: RESOLVED INVALID

(DevTools :: Netmonitor, enhancement, P3)

Description

[Alexandre Poirot [:ochameau]]

Bug 1425964 helped highlighting a coverage miss for netmonitor DAMP tests.

The waterfall doesn't render until waterfallWidth is set:
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/widgets/WaterfallBackground.js#52

But waterfallWidth is only set after an idle callback is fired from here:
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/components/RequestListHeader.js#96-98

Finally, on DAMP, tests are run subsequently without any pause. Thus, preventing any idle callback to be fired.
So all DAMP tests run without any update done to the waterfall.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1426206 - Ensure rendering the waterfall while running DAMP tests related to netmonitor.

Review commit: https://reviewboard.mozilla.org/r/208482/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208482/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8937772 [details]
Bug 1426206 - Ensure rendering the waterfall while running DAMP tests related to netmonitor.

https://reviewboard.mozilla.org/r/208482/#review214412

Nice catch, Thanks Alex!

R+

Honza

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Alex, shouldn't we land this?

Honza

Comment 4

[Alexandre Poirot [:ochameau]]

I rebased that old patch and it doesn't seem to provide any change.
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=a698b89b920e16176458969c39d3edf16937c359&originalSignature=4763542&newSignature=4763542&framework=12&application=firefox&originalRevision=ae397d2226aa664185666c7a7f46d599f9bd0cac&page=1&showOnlyConfident=1
Let's assume it is no longer relevant.