142627 - Selection on Copies and Folders pane doesn't hold

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[ji]

Build: win32 05/06 1.0.0 branch build

With above build, the change on Copies and Folders pane doesn't hold.

Steps to reproduce:
1. Luanch browser with above build and setup an IMAP account with the profile.
2. Select Edit | Mail and News Account Settings | Copies and Folders, observe
that no default selection for Draft and Template
3. Select a folder for drafts and templates and click on OK to save the change
and close the window.
4. Select Edit | Mail and News Account Settings | Copies and Folders again, you
can see the selection you did for Draft and Template is gone, so is the
selection for Sent.

Comment 1

[ji]

CC'ed to Navin.

Comment 2

[Navin Gupta]

I have touched this code recently. I'm looking at it now. 

Comment 3

[Navin Gupta]

*** Bug 142630 has been marked as a duplicate of this bug. ***

Comment 4

[scottputterman]

asking the same question as in the dup:

Once this happens are you unable to copy a message to a sent folder or is the ui
just messed up?

I just wanted to verify that there's no way to get this back.

Comment 5

[Ninoschka Baca]

Responding to comment#3: It appears to not accept the changes so the default
settings (in the backgroun) are maintained while it displays "Click here to
select a folder" in the dropdown menus. 

Another scenario using an existing profile:
1. In an existing profile I have two accounts:
- nbaca
- qates20
2. I change the Draft settings for qatest20 to a Local Folder
3. Close/reopen the Account Settings dialog now the Drafts settings state "Click
here to select a folder" and so does the Templates drop down.
4. I also notice that the nbaca/Copies and Folders settings all state "Click
here to select a folder" so this problem effects other accounts in the profile
5. With qatest20 selected I Save As Draft and it saves it to the qatest20/draft
folder so it appears that it did not take the change to Local Folders but is
working based on the default settings. The same is true for the nbaca account.

The user should be able to change their settings and have them honored as well
as displayed correctly in the Copies and Folders panel.

Comment 6

[Navin Gupta]

taking, I broke it. I should not have cleaned up that gMessengerBundle, infact I
told bhuvan that we should not clean-up anything if it is going on branch. 

patch upcoming. 

Comment 7

[Navin Gupta]

Attachment: patch

gMessengerBundle is used by msgFolderPickerOverlay.js. bhuvan, can you review ?
thx.

Comment 8

[Navin Gupta]

Attachment: better patch

we just need to define string bundle in xul file, pickerOverlay looks for
'bundle_messenger'.

Comment 9

[racham]

Comment on attachment 82552 [details] [diff] [review]
better patch

Navin, Before checking in, can you add comments above that stringbundle
inclusion saying that this is used in msgFolderPickerOverlay. No need for a new
patch. thanks.

r=bhuvan

Comment 10

[David :Bienvenu]

Comment on attachment 82552 [details] [diff] [review]
better patch

sr=bienvenu

Comment 11

[Navin Gupta]

fixed on trunk

Comment 12

[Jaime Rodriguez, Jr.]

Ninoschka - Can you verify asap, or can Naving give you a branch build to
verify? We'd like to take this, but we'd like to have QA verify it fixed,
without any regressions.

Comment 13

[Syd Logan]

One way to accelerate testing on this would be to install last night's branch,
unpack the jar file containing this XUL, replace the old version of this XUL
with the new version, repack the jar, and see if the fix works. If that can be
done sometime in the next hour or two to verify, we can get this on the branch
(with suitable approvals of course).

Comment 14

[Navin Gupta]

Ninoschka has done some preliminary testing on my trunk debug build and it looks
ok, she will do a more formal testing on trunk bits tomorrow. I think we can wait
until tomorrow.

Comment 15

[Navin Gupta]

we (bhuvan, ninoschka, me) were able to do what syd suggested. Ninoschka is busy
verifying. 

Comment 16

[Asa Dotzler [:asa]]

Comment on attachment 82552 [details] [diff] [review]
better patch

a=asa (on behalf of drivers) for checkin to the 1.0 branch.

Comment 17

[Ninoschka Baca]

After manipulating the files using the branch build as Syd suggested, it appears
to be working. I tried the following scenario on a WinMe system:

1. New profile, added an IMAP account, added a POP account
a. Edited all Sent, Drafts, Templates settings
b. Closed Account Settings
c. Opened Account Settings and Copies & Folders panel looks correct
d. Also able to Send, Save As Draft, Save As Template with messages going to the
correct folders. 
e. After an exit/restart the new settings still remained

2. Migrated a POP profile, added an IMAP account, added a News account
a. Performed similar steps as 1a-1e and all settings were saved and functions
performed properly.

Comment 18

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) approval for checkin to the 1.0 brnach. Pls check
this in tonight, then add the fixed1.0.0 keyword.

Comment 19

[racham]

Navin, 

I can check this in for you. Will wait for some more time. If you are around or
logged in from home, please do update the bug about your branch checkin plan.
Otherwise, I will go ahead check it in so that tomorrow's branch build will have
the patch.

Comment 20

[racham]

ok. I am going to check this in (on branch).

Comment 21

[racham]

Landed on branch. Adding fixed1.0.0 keyword.

Comment 22

[Ninoschka Baca]

*** Bug 142725 has been marked as a duplicate of this bug. ***

Comment 23

[Ninoschka Baca]

Branch build 2002-05-07-06: WinMe, fixed.

Tried a variety of scenarios where the Copies & Folder settings were changed to
point to the same server but a different folder, a different account, and also
to Local Folders:
1. Existing profile with IMAP and POP account
2. New profile with POP, AOL and WebMail account

Checking linux and mac next.

Comment 24

[Ninoschka Baca]

Branch build 2002-05-07: Linux RH 7.1, Mac 9,1
Mozilla branch build 2002-05-07: Mac X
Verified Fixed on the branch.

Will have to check trunk builds next.

Comment 25

[Ninoschka Baca]

Trunk build 2002-07-09: WinMe, Linux RH 7.1, Mac 10.1.3
Verified Fixed.