1426350 - Move tab context menu tests to browser/base/content/test/tabs/

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P1)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1426350 - Move tab context menu tests to browser/base/content/test/tabs/.

Review commit: https://reviewboard.mozilla.org/r/208670/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208670/

Comment 2

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1858d07ba28dcfa859677545a98ef8eb612ddf34

Comment 3

[:Gijs (he/him)]

Comment on attachment 8937959 [details]
Bug 1426350 - Move tab context menu tests to browser/base/content/test/tabs/.

https://reviewboard.mozilla.org/r/208670/#review214484

Nice, thanks!

::: browser/base/content/test/sync/browser_contextmenu_sendtab.js:18
(Diff revision 1)
> +  var evt = new Event("");
> +  tab.dispatchEvent(evt);

I know we're kinda cargo-culting this, but seeing as you removed the waiting for the popup to be hidden... what does this event dispatching accomplish? Can we remove that too?

Comment 4

[Dão Gottwald [:dao]]

(In reply to :Gijs from comment #3)
> Comment on attachment 8937959 [details]
> Bug 1426350 - Move tab context menu tests to browser/base/content/test/tabs/.
> 
> https://reviewboard.mozilla.org/r/208670/#review214484
> 
> Nice, thanks!
> 
> ::: browser/base/content/test/sync/browser_contextmenu_sendtab.js:18
> (Diff revision 1)
> > +  var evt = new Event("");
> > +  tab.dispatchEvent(evt);
> 
> I know we're kinda cargo-culting this, but seeing as you removed the waiting
> for the popup to be hidden... what does this event dispatching accomplish?
> Can we remove that too?

It's there so it can be passed to openPopup as the triggering event.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df5f2fa581c5
Move tab context menu tests to browser/base/content/test/tabs/. r=Gijs

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/df5f2fa581c5