Move tab context menu tests to browser/base/content/test/tabs/

RESOLVED FIXED in Firefox 59

Status

()

Firefox
Tabbed Browser
P1
normal
RESOLVED FIXED
28 days ago
26 days ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
Comment hidden (mozreview-request)

Comment 3

28 days ago
mozreview-review
Comment on attachment 8937959 [details]
Bug 1426350 - Move tab context menu tests to browser/base/content/test/tabs/.

https://reviewboard.mozilla.org/r/208670/#review214484

Nice, thanks!

::: browser/base/content/test/sync/browser_contextmenu_sendtab.js:18
(Diff revision 1)
> +  var evt = new Event("");
> +  tab.dispatchEvent(evt);

I know we're kinda cargo-culting this, but seeing as you removed the waiting for the popup to be hidden... what does this event dispatching accomplish? Can we remove that too?
Attachment #8937959 - Flags: review?(gijskruitbosch+bugs) → review+
(Assignee)

Comment 4

27 days ago
(In reply to :Gijs from comment #3)
> Comment on attachment 8937959 [details]
> Bug 1426350 - Move tab context menu tests to browser/base/content/test/tabs/.
> 
> https://reviewboard.mozilla.org/r/208670/#review214484
> 
> Nice, thanks!
> 
> ::: browser/base/content/test/sync/browser_contextmenu_sendtab.js:18
> (Diff revision 1)
> > +  var evt = new Event("");
> > +  tab.dispatchEvent(evt);
> 
> I know we're kinda cargo-culting this, but seeing as you removed the waiting
> for the popup to be hidden... what does this event dispatching accomplish?
> Can we remove that too?

It's there so it can be passed to openPopup as the triggering event.

Comment 5

27 days ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df5f2fa581c5
Move tab context menu tests to browser/base/content/test/tabs/. r=Gijs

Comment 6

26 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/df5f2fa581c5
Status: ASSIGNED → RESOLVED
Last Resolved: 26 days ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.