1426369 - Turn off TFO if needed

Status: RESOLVED WONTFIX

(Core :: Networking: HTTP, enhancement, P3)

Description

[Dragana Damjanovic [:dragana]]

I will prepare a patch to turn off TFO if it is needed.

The holidays are coming and peaople will be unreachable, so I will prepare a patch that can be just pushed if needed.

Comment 1

[Dragana Damjanovic [:dragana]]

Attachment: bug_1426369.patch

This patch is just in case we need to disable tfo fast :)

Comment 2

[u408661]

Comment on attachment 8938106 [details] [diff] [review]
bug_1426369.patch

Review of attachment 8938106 [details] [diff] [review]:
-----------------------------------------------------------------

Always good to have a panic patch :)

Comment 3

[Liz Henry (:lizzard)]

What a good idea. Tracking this for 59 so I have it on my radar.

Comment 4

[Liz Henry (:lizzard)]

Dragana, would this still apply to beta if we need to turn TFO off for 59?

Comment 5

[Dragana Damjanovic [:dragana]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #4)
> Dragana, would this still apply to beta if we need to turn TFO off for 59?

Yes, it will apply.

I want to land bug 1431738 that enables TFO only on Early_BETA or earlier, so that it will not slip to release. If we want to ship it we will turn it on explicitly on release.

Comment 6

[anhtuanho]

Comment on attachment 8938106 [details] [diff] [review]
bug_1426369.patch

is it my bug ?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Bug 1431738 has been uplifted to mozilla-beta now, where EARLY_BETA_OR_EARLIER was already unset prior to building 59b7. Therefore, updating the status for this bug to disabled.

Comment 8

[Dragana Damjanovic [:dragana]]

We do not need this patch any more.