Closed
Bug 1426376
Opened 6 years ago
Closed 6 years ago
Update xpcshell tests to avoid obsolete do_* helpers (port bug bug 1421992 to c-c)
Categories
(Thunderbird :: Testing Infrastructure, defect)
Thunderbird
Testing Infrastructure
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 59.0
People
(Reporter: florian, Assigned: florian)
Details
Attachments
(1 file)
|
3.14 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
Bug 1421992 will be landing soon in mozilla-central, and will remove: do_check_true, do_check_false, do_check_eq, do_check_neq, do_check_null, do_check_matches It'll also rename do_print to info, do_register_cleanup to registerCleanupFunction and do_execute_soon to executeSoon. I sent an intent to remove post at https://groups.google.com/forum/#!topic/mozilla.dev.platform/IrzGkgr0xJk
|
Assignee | |
Comment 1•6 years ago
|
||
attachment 8937978 [details] [diff] [review] / attachment 8937979 [details] [diff] [review] in bug 1421992 comment 22 and bug 1421992 comment 23 were meant to go in this bug. Fallen, you can r+ them in bug 1421992, but let's keep comm-central discussion (or try pushes) in this separate bug.
Component: Build Config → Testing Infrastructure
OS: Unspecified → All
Hardware: Unspecified → All
Version: unspecified → Trunk
|
||
Comment 2•6 years ago
|
||
I don't see what this bug is for. The action is happening in 1421992, even the commit messages have that bug number, so nothing will get logged here.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
|
|
Assignee | |
Comment 3•6 years ago
|
||
We are lucky, https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=977d47e829bd0ce3cb253b459826565743400a09 shows only 2 broken xpcshell tests on c-c.
Attachment #8938331 -
Flags: review?(philipp)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → florian
|
||
Updated•6 years ago
|
Attachment #8938331 -
Flags: review?(philipp) → review+
|
|
||
Comment 4•6 years ago
|
||
I'll get this landed later on.
Pushed by florian@queze.net: https://hg.mozilla.org/comm-central/rev/eebd75773de6 fix broken mailnews xpcshell tests, r=Fallen.
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
|
|
||
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 59.0
You need to log in
before you can comment on or make changes to this bug.
Description
•