1426395 - Crash in mozilla::dom::cache::ReadStream::Inner::EnsureStream

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect, P3)

Description

[Jean-Yves Avenard [:jya]]

like: 

https://crash-stats.mozilla.com/report/index/fd740e2f-62c0-4caa-85a8-10e380171220

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

This code needs to handle spurious wakeups from the condition variable:

https://en.wikipedia.org/wiki/Spurious_wakeup

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

I guess the problem is actually this, instead:

MOZ_CRASH(Blocking read on the js/ipc owning thread!)

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Or maybe its not comment 2 since the stack trace is non-main-thread and also doesn't show anything about worker threads.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

This seems like broken TLS to me.  I've seen some other low-frequency crashes recently that also seemed related to TLS not working correctly.

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

This also hasn't had any crashes in 57 release channel for some reason.

I think I'm going to monitor this for now.  Its unclear what we can do here.

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Its also possible the ReadableStream is garbage I suppose and the TLS check is failing because mOwningEventTarget is a bad pointer.

Comment 7

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals

Comment 8

[Ben Kelly [:bkelly, not reviewing]]

I'm not actively working this.  Its very low frequency and I don't have any good options to move forward at the moment.

Comment 9

[Wayne Mery (:wsmwk)]

(a reduction in crash frequency or bug priority shouldn't change bug Severity)

No crashes in version 61, i.e. after 60.0.2.  So => WFM?

https://crash-stats.mozilla.com/signature/?signature=mozilla%3A%3Adom%3A%3Acache%3A%3AReadStream%3A%3AInner%3A%3AEnsureStream&date=%3E%3D2018-06-05T03%3A45%3A45.000Z&date=%3C2018-09-05T03%3A45%3A45.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1#reports

Comment 10

[Andrew Overholt [:overholt]]

Thanks, Wayne.