Closed Bug 1426439 Opened 5 years ago Closed 5 years ago

Display stacks for timed out tests

Categories

(Core :: JavaScript Engine, enhancement)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: sfink, Assigned: sfink)

References

Details

Attachments

(1 file)

Allow stack reporting for timed out tests
3.41 KB, patch
jonco
: review+
Details | Diff | Splinter Review 
Now that we can produce stacks for unexpected test crashes, it seems like it would also be useful to get stacks for timed out tests, to hopefully provide a single-sample insight into what is taking so long (or if it's completely hung.)
Note that the stacks for regular crashes have been broken; I had swapped out a binary to one that didn't work. I may land the fix for that together with this patch, or perhaps I'll land the other one first.
Attachment #8938058 - Flags: review?(jcoppeard)
Comment on attachment 8938058 [details] [diff] [review]
Allow stack reporting for timed out tests

Review of attachment 8938058 [details] [diff] [review]:
-----------------------------------------------------------------

Great idea.
Attachment #8938058 - Flags: review?(jcoppeard) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/47eabc18d294
Allow stack reporting for timed out tests, r=jonco
https://hg.mozilla.org/mozilla-central/rev/47eabc18d294
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.