1426442 - On Nightly, minimized un-restored windows don't display correctly in the dock

Status: NEW

(Core :: Widget: Cocoa, defect, P3)

Description

[Haik Aftandilian [:haik]]

Attachment: dock-with-minimized-icons.png

On Nightly, after restarting the browser, windows that were minimized to the dock don't display correctly. In the attached screenshot, the Firefox 57 minimized icons display as small windows with the Firefox logo overlaid. On Nightly 59, a black bar is drawn at the top of where the window would be with the logo overlaid, but no window border.

Actual result:
Minimized icons in the dock don't look like a mini window.

Expected result:
For un-restored windows, the dock would display a placeholder blank window with the Nightly logo overlaid.

Tested on macOS 10.13.2, MacBook Pro (Retina, 15-inch, Mid 2015).

Comment 1

[Stephen A Pohl [:spohl] (OOO until 1/26)]

Is this a regression?

Comment 2

[Stephen A Pohl [:spohl] (OOO until 1/26)]

Or are you saying the expected behavior is the behavior in 57?

Comment 3

[Haik Aftandilian [:haik]]

(In reply to Stephen A Pohl [:spohl] from comment #2)
> Or are you saying the expected behavior is the behavior in 57?

Yes, with Firefox 57, the icons look right.

I tested on Beta 58 and the bug shows up there too.

Working on a mozregression.

Comment 4

[Stephen A Pohl [:spohl] (OOO until 1/26)]

I was going to say that bug 1405577 may have to do with this. But Beta 58 doesn't have that patch. Thanks for getting a mozregression.

Comment 5

[Haik Aftandilian [:haik]]

mozregression led me to the SDK updates:

$ mozregression --profile-persistence reuse --good 56 --bad 58
...
12:50.99 INFO: No more inbound revisions, bisection finished.
12:50.99 INFO: Last good revision: a85670ee5e959299556b6ad0ef1370743debc43d
12:50.99 INFO: First bad revision: 8a67124d36d9ed0c6fa9111ae33620aeddc4ce4d
12:50.99 INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a85670ee5e959299556b6ad0ef1370743debc43d&tochange=8a67124d36d9ed0c6fa9111ae33620aeddc4ce4d

Bug 1324892: Update toolchain paths to point to the macOS 10.11 SDK. r=ted
Bug 1324892: Fix tests for switch to macOS SDK 10.11. r=mstange
Bug 1324892: Update Mac builds to use the OS X 10.11 SDK. r=mshal

Comment 6

[Haik Aftandilian [:haik]]

I thought 57 did not have this problem, but I can now reproduce it on 57 and it seems to be profile-specific.

On 57, using a profile I've carried forward for several releases, minimized un-restored dock icons look correct after a restart.

However, after I tried the same test on 57 with a fresh profile, I do hit the problem.

Comment 7

[Stephen A Pohl [:spohl] (OOO until 1/26)]

Thank you for the additional info!

Comment 8

[Haik Aftandilian [:haik]]

Attachment: Dock with missing window preview icons - Firefox 91

I'm hitting this reliably on Firefox 91 on 11.5.2. In this case, the titlebar isn't drawn so it looks a little worse compared to the Nightly screenshot from comment 0. Leaving a needinfo for myself to debug further.

Firefox 91.0.2 (64-bit)
macOS Big Sur
Version 11.5.2 (20G95)
MacBook Air (Retina, 13-inch, 2018)
1.6 GHz Dual-Core Intel Core i5
8 GB 2133 MHz LPDDR3
Intel UHD Graphics 617 1536 MB

Comment 9

[Haik Aftandilian [:haik]]

I haven't found the time to make progress on this so I'm letting this go to the backlog. It doesn't reproduce for me on macOS 10.15 and newer.

Comment 10

[Haik Aftandilian [:haik]]

Attachment: Problem occurring on macOS 14.3.1 (23D60) with Nightly 125 (2024-03-04)

Comment 11

[Haik Aftandilian [:haik]]

I have hit this again on macOS 14.3.1 (23D60) with Nightly 125 (2024-03-04), but it is not reproducible so far. More debugging needed.

Comment 12

[Haik Aftandilian [:haik]]

Now I'm hitting this problem on macOS 14.4.1 (23E224) with Apple apps such as System Preferences and Apple Photos indicating it is likely to be a macOS bug. I'll report it and include the FB # here.

Comment 13

[Haik Aftandilian [:haik]]

Attachment: Instance of the problem with the Apple Photos app and Nightly

Comment 14

[Haik Aftandilian [:haik]]

Have not reproduced this since comment 12.