1426446 - Make buttons in unverified Sync state more clear

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Ryan Feeley [:rfeeley]]

Attachment: improve-unverified-buttons.png

When the user has not yet verified, the buttons in Sync prefs are not clear (and should also be title case).

Please change them to the following (see attached).

Comment 1

[Edouard Oger [:eoger]]

Do you mean "Resent" or "Resend" verification Ryan?

Comment 2

[Ryan Feeley [:rfeeley]]

"Resend", thanks for spotting that. Too many careless errors these last days. I'm burned out. I am taking PTO today.

Comment 3

[Edouard Oger [:eoger]]

Attachment: Bug 1426446 - Change buttons labels in unverified state.

Review commit: https://reviewboard.mozilla.org/r/209066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209066/

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Ryan, I'm a little concerned about "Remove Account" - I suspect some users will decide that it means "Delete Account", but it doesn't. ISTM that "Disconnect Account" might be better, but ultimately it is your call - thanks!

Comment 5

[Francesco Lodolo [:flod]]

Comment on attachment 8938344 [details]
Bug 1426446 - Change buttons labels in unverified state.

https://reviewboard.mozilla.org/r/209066/#review215540

::: browser/locales/en-US/chrome/browser/preferences/sync.dtd:76
(Diff revision 1)
> -<!ENTITY disconnect3.label           "Disconnect…">
> -<!ENTITY disconnect3.accesskey       "D">
> -<!ENTITY verify.label                "Verify email">
> -<!ENTITY verify.accesskey            "V">
> -<!ENTITY forget.label                "Forget this email">
> -<!ENTITY forget.accesskey            "F">
> +<!ENTITY disconnect3.label            "Disconnect…">
> +<!ENTITY disconnect3.accesskey        "D">
> +<!ENTITY resendVerification.label     "Resend Verification">
> +<!ENTITY resendVerification.accesskey "V">
> +<!ENTITY removeAccount.label          "Remove Account">
> +<!ENTITY removeAccount.accesskey      "F">

You need to pick a letter available in the new label.

Comment 6

[Ryan Feeley [:rfeeley]]

Thanks all! I forgot about access keys. Can I use new copy? Meridel (our copywriter) and I spoke about this.

We settled on:

1. Resend Verification (R)
2. Cancel Setup (C)

Would these work?

Comment 7

[Mark Hammond [:markh] [:mhammond]]

new copy is fine so long as we change string IDs (and Ed knows all about that).

Comment 8

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8938344 [details]
Bug 1426446 - Change buttons labels in unverified state.

Clearing review request until Ed get's a new patch up with the new strings.

Comment 9

[Edouard Oger [:eoger]]

Comment on attachment 8938344 [details]
Bug 1426446 - Change buttons labels in unverified state.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/209066/diff/1-2/

Comment 10

[Edouard Oger [:eoger]]

The accesskeys Ryan mentioned were taken, I had to go for:

<!ENTITY resendVerification.label     "Resend Verification">
<!ENTITY resendVerification.accesskey "d">
<!ENTITY cancelSetup.label            "Cancel Setup">
<!ENTITY cancelSetup.label            "p">

Comment 11

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8938344 [details]
Bug 1426446 - Change buttons labels in unverified state.

https://reviewboard.mozilla.org/r/209066/#review216016

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d263263c0c77
Change buttons labels in unverified state. r=markh

Comment 13

[Andreea Pavel [:apavel]]

Backed out for failing browser/components/preferences/in-content/tests/browser_search_within_preferences_2.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=6a44449562d57024cff1d6bf09b1e0c191b45694

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=154238970&repo=autoland&lineNumber=6373

Backout: https://hg.mozilla.org/integration/autoland/rev/e4bba88811c07450019d179338af382066be3ce2

Comment 14

[Edouard Oger [:eoger]]

Comment on attachment 8938344 [details]
Bug 1426446 - Change buttons labels in unverified state.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/209066/diff/2-3/

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aada2cb196cf
Change buttons labels in unverified state. r=markh

Comment 16

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/aada2cb196cf