Closed Bug 1426452 Opened 2 years ago Closed 2 years ago

Remove Makefile check in CompileDB backend

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement
Priority:
Not set

Tracking

(firefox59 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: mshal, Assigned: mshal)

Details

Attachments

(1 file)

Bug 1426452 - Remove check_top_objdir() call from CompileDB;
59 bytes, text/x-review-board-request
chmanchester
: review+
Details 
Since bug 1224450, the CompileDB backend no longer needs the topobjdir/Makefile to get variable information. We can remove the check_top_objdir() call so the CompileDB can be built even if the RecursiveMake backend is not.
Comment on attachment 8938156 [details]
Bug 1426452 - Remove check_top_objdir() call from CompileDB;

https://reviewboard.mozilla.org/r/208808/#review214650
Attachment #8938156 - Flags: review+
Attachment #8938156 - Flags: review?(core-build-config-reviews)
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d8e5cace54dc
Remove check_top_objdir() call from CompileDB; r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/d8e5cace54dc
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.