Closed
Bug 1426478
Opened 6 years ago
Closed 6 years ago
BinJS files need modelines and license boilerplate
Categories
(Core :: JavaScript Engine, enhancement, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: jandem, Assigned: Yoric)
References
Details
Attachments
(1 file)
Noticed this because Emacs was using tabs instead of spaces while editing BinSource.cpp See for instance Parser.h: https://searchfox.org/mozilla-central/rev/ff462a7f6b4dd3c3fdc53c9bc0b328f42a5b3d2b/js/src/frontend/Parser.h#1-5
Flags: needinfo?(dteller)
Updated•6 years ago
|
Priority: -- → P1
Assignee | ||
Comment 1•6 years ago
|
||
Ah, good catch, thanks.
Assignee: nobody → dteller
Flags: needinfo?(dteller)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8943191 [details] Bug 1426478 - Adding license boilerplate to binjs source files; https://reviewboard.mozilla.org/r/213544/#review219234 This patch only affects license boilerplate. Self-reviewing.
Assignee | ||
Updated•6 years ago
|
Attachment #8943191 -
Flags: review?(dteller)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8943191 [details] Bug 1426478 - Adding license boilerplate to binjs source files; https://reviewboard.mozilla.org/r/213546/#review219238
Attachment #8943191 -
Flags: review?(dteller) → review+
Pushed by dteller@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/990bb647f218 Adding license boilerplate to binjs source files;r=Yoric
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/990bb647f218
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•