BinJS files need modelines and license boilerplate

RESOLVED FIXED in Firefox 59

Status

()

Core
JavaScript Engine
P1
normal
RESOLVED FIXED
a month ago
4 days ago

People

(Reporter: jandem, Assigned: Yoric)

Tracking

unspecified
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a month ago
Noticed this because Emacs was using tabs instead of spaces while editing BinSource.cpp

See for instance Parser.h:

https://searchfox.org/mozilla-central/rev/ff462a7f6b4dd3c3fdc53c9bc0b328f42a5b3d2b/js/src/frontend/Parser.h#1-5
Flags: needinfo?(dteller)
Priority: -- → P1
Ah, good catch, thanks.
Assignee: nobody → dteller
Flags: needinfo?(dteller)
Comment hidden (mozreview-request)
(Assignee)

Comment 3

4 days ago
mozreview-review
Comment on attachment 8943191 [details]
Bug 1426478 - Adding license boilerplate to binjs source files;

https://reviewboard.mozilla.org/r/213544/#review219234

This patch only affects license boilerplate. Self-reviewing.
Attachment #8943191 - Flags: review?(dteller)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 6

4 days ago
mozreview-review
Comment on attachment 8943191 [details]
Bug 1426478 - Adding license boilerplate to binjs source files;

https://reviewboard.mozilla.org/r/213546/#review219238
Attachment #8943191 - Flags: review?(dteller) → review+

Comment 7

4 days ago
Pushed by dteller@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/990bb647f218
Adding license boilerplate to binjs source files;r=Yoric

Comment 8

4 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/990bb647f218
Status: NEW → RESOLVED
Last Resolved: 4 days ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.