Closed Bug 1426504 Opened 2 years ago Closed 2 years ago

All builds are going to permafail when Gecko 59 merges to Beta on 2018-01-11

Categories

(Core :: JavaScript Engine, defect, blocker)

defect
Not set
blocker

Tracking

()

VERIFIED FIXED
mozilla59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 + verified

People

(Reporter: RyanVM, Assigned: RyanVM)

Details

Attachments

(1 file)

[Tracking Requested - why for this release]: Mass build bustage on the next merge day.

This is actively blocking me from running uplift simulations on Try, so this is high urgency. Waldo, I assume this is bustage from one of the bugs you landed recently that touched Parser.cpp?

https://treeherder.mozilla.org/logviewer.html#?job_id=152708876&repo=try

js/src/frontend/Parser.cpp:3777:72: error: there are no arguments to 'addTelemetry' that depend on a template parameter, so a declaration of 'addTelemetry' must be available [-fpermissive]
js/src/frontend/Parser.cpp:3777:25: error: 'addTelemetry' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
js/src/frontend/Parser.cpp:3777:25: error: 'addTelemetry' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
Flags: needinfo?(jwalden+bmo)
Assignee: nobody → ryanvm
Attachment #8938155 - Flags: review?(jdemooij)
Flags: needinfo?(jwalden+bmo)
Comment on attachment 8938155 [details] [diff] [review]
add missing this>

Review of attachment 8938155 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. Hopefully expression closures will be removed soon.
Attachment #8938155 - Flags: review?(jdemooij) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce1ee748c8eb
Add missing this-> to fix mass bustage when Gecko 59 merges to Beta. r=jandem
Tracking just to make sure this lands and sticks.
The alternative fix that I probably would have done would have been to add

#if JS_HAS_EXPR_CLOSURES
    using ParserBase::addTelemetry;
#endif

to the private using-list in GeneralParser, but this works too.  Mostly just aesthetics, and |this->|-qualifying is probably safer in that we wouldn't have to also be sure to get rid of the |using PB::addTelemetry;| when expression closures are actually removed.
https://hg.mozilla.org/mozilla-central/rev/ce1ee748c8eb
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.