jsstr.c's dollarStr static is just plain wrong

VERIFIED FIXED in mozilla1.0

Status

()

VERIFIED FIXED
17 years ago
7 years ago

People

(Reporter: brendan, Assigned: brendan)

Tracking

({js1.5})

Trunk
mozilla1.0
js1.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
Two threads racing through interpret_dollar and its caller do_replace could end
up both using the same pointer, but only one use would be valid.  The other use
could even dangle, given unlikely but bad thread scheduling.

This is a fix-for-1.0 candidate.

/be
(Assignee)

Updated

17 years ago
Keywords: js1.5, mozilla1.0
Target Milestone: --- → mozilla1.0
(Assignee)

Comment 1

17 years ago
Created attachment 82556 [details] [diff] [review]
proposed fix

You cc: listers can r= and sr= fast, I bet.

Phil, can you test and vouch for this patch?  Thanks.

/be
Comment on attachment 82556 [details] [diff] [review]
proposed fix

Threadsafety.  It's what's for dinner.

sr=shaver.
Attachment #82556 - Flags: superreview+

Comment 3

17 years ago
The patch passes the JS testsuite in the debug JS shell on WinNT, Linux.
Am now testing it in the optimized shell...

Comment 4

17 years ago
The patch passes the JS testsuite in the optimized JS shell, as well -

Comment 5

17 years ago
Comment on attachment 82556 [details] [diff] [review]
proposed fix

r=jband
Attachment #82556 - Flags: review+

Comment 6

17 years ago
Comment on attachment 82556 [details] [diff] [review]
proposed fix

a=asa (on behalf of drivers) for checkin to the 1.0 branch
Attachment #82556 - Flags: approval+
(Assignee)

Comment 7

17 years ago
Fixed in the 1.0 branch as well as the trunk.

/be
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 8

17 years ago
Patch verified on 1.0 branch as well as on trunk;
adding fixed1.0.0 and verified1.0.0 keywords -
Status: RESOLVED → VERIFIED
Keywords: fixed1.0.0, verified1.0.0
You need to log in before you can comment on or make changes to this bug.