Closed
Bug 1426516
Opened 6 years ago
Closed 6 years ago
Make ::slotted(..) use the rule hash (whitelisting the valgrind false-positive).
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Landing bug 1425757 caused a valgrind failure like: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=f58dca05f26f69116bf5a736d384e97963beec61&selectedJob=152699403&filter-searchStr=71c65f839aa0a31806ffba7d7a50d5642e7c7c45 I worked around it in https://github.com/servo/servo/pull/19613. We should whitelist it and re-enable it, probably.
|
Assignee | |
Comment 1•6 years ago
|
||
Julian, could you take a look when you have the time? (Definitely not urgent, but...)
Flags: needinfo?(jseward)
|
||
Updated•6 years ago
|
Priority: -- → P1
Here's a direct link to the failure, since that "fromchange" link will get unwieldy over time: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=248cd7331f4a35a03b0c347122efbeed0a12b093&filter-searchStr=71c65f839aa0a31806ffba7d7a50d5642e7c7c45&selectedJob=152699403
|
|
||
Updated•6 years ago
|
Priority: P1 → P3
|
|
Assignee | |
Comment 3•6 years ago
|
||
Ping here Julian?
|
|
Assignee | |
Comment 4•6 years ago
|
||
Doesn't seem to happen in master anymore, will reland it.
Flags: needinfo?(jseward)
|
|
Assignee | |
Comment 5•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=10da1ee49cc26920633b483aecc0a596ec389e12 for reference.
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a5dcdb37129d Remove Valgrind workaround to make ::slotted use the rule hash. r=me
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a5dcdb37129d
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
|
||
Updated•6 years ago
|
Assignee: nobody → emilio
You need to log in
before you can comment on or make changes to this bug.
Description
•