Closed Bug 1426516 Opened 3 years ago Closed 2 years ago
Make ::slotted(..) use the rule hash (whitelisting the valgrind false-positive).
Landing bug 1425757 caused a valgrind failure like: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=f58dca05f26f69116bf5a736d384e97963beec61&selectedJob=152699403&filter-searchStr=71c65f839aa0a31806ffba7d7a50d5642e7c7c45 I worked around it in https://github.com/servo/servo/pull/19613. We should whitelist it and re-enable it, probably.
Julian, could you take a look when you have the time? (Definitely not urgent, but...)
Here's a direct link to the failure, since that "fromchange" link will get unwieldy over time: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=248cd7331f4a35a03b0c347122efbeed0a12b093&filter-searchStr=71c65f839aa0a31806ffba7d7a50d5642e7c7c45&selectedJob=152699403
Ping here Julian?
Doesn't seem to happen in master anymore, will reland it.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a5dcdb37129d Remove Valgrind workaround to make ::slotted use the rule hash. r=me
You need to log in before you can comment on or make changes to this bug.