Closed Bug 1426526 Opened 2 years ago Closed Last month

Trim down or remove file_util*

Categories

(Core :: IPC, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: mccr8, Assigned: jld)

References

Details

Attachments

(2 files)

The functions declared in this header seem to be mostly unused. There are a few that seem to be used by shmem related things, such as GetShmemTempDir.
Summary: Trim down or remove file_util.h → Trim down or remove file_util*
Priority: -- → P3
I was going to file a bug for this, because I was looking into using shm_open (bug 1447867) for shared memory and wound up deleting all of file_util, but it turns out there already is one.

The one other user of file_util is rand_util, which uses ReadFromFd on /dev/urandom, but I just gave it a static copy of that one function.
Assignee: nobody → jld
Depends on: 1447867

Note to self: also remove this reference to the org.chromium prefix (from bug 1510574).

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jld, could you have a look please?

Flags: needinfo?(jld)

This is part of a series of patches that's being held until the next merge cycle.

Flags: needinfo?(jld)

With the removal of the old Chromium file_util code, we should no longer
be using temporary files with names starting with "org.chromium.", so the
crash reporter and main thread I/O test no longer need to recognize that
prefix.

Pushed by jedavis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7cf4735a088f
Delete file_util from ex-Chromium IPC source. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/510f03381af9
Remove references to the old Chromium temporary file prefix. r=gsvelto,florian
Pushed by jedavis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d892a888fe9c
Delete file_util from ex-Chromium IPC source. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/2ea5ccb8f3a1
Remove references to the old Chromium temporary file prefix. r=gsvelto,florian
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla69 → ---
Flags: needinfo?(jld)
Pushed by jedavis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f936472f7576
Delete file_util from ex-Chromium IPC source. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/87737e44c8b7
Remove references to the old Chromium temporary file prefix. r=gsvelto,florian
Status: REOPENED → RESOLVED
Closed: 3 months agoLast month
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.