1426526 - Trim down or remove file_util*

Status: RESOLVED FIXED

(Core :: IPC, enhancement, P3)

Description

[Andrew McCreight [:mccr8]]

The functions declared in this header seem to be mostly unused. There are a few that seem to be used by shmem related things, such as GetShmemTempDir.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

I was going to file a bug for this, because I was looking into using shm_open (bug 1447867) for shared memory and wound up deleting all of file_util, but it turns out there already is one.

The one other user of file_util is rand_util, which uses ReadFromFd on /dev/urandom, but I just gave it a static copy of that one function.

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Note to self: also remove this reference to the org.chromium prefix (from bug 1510574).

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Bug 1426526 - Delete file_util from ex-Chromium IPC source.

Depends on D26746

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jld, could you have a look please?

Comment 5

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

This is part of a series of patches that's being held until the next merge cycle.

Comment 6

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Bug 1426526 - Remove references to the old Chromium temporary file prefix.

With the removal of the old Chromium file_util code, we should no longer
be using temporary files with names starting with "org.chromium.", so the
crash reporter and main thread I/O test no longer need to recognize that
prefix.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cf4735a088f
Delete file_util from ex-Chromium IPC source. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/510f03381af9
Remove references to the old Chromium temporary file prefix. r=gsvelto,florian

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d892a888fe9c
Delete file_util from ex-Chromium IPC source. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/2ea5ccb8f3a1
Remove references to the old Chromium temporary file prefix. r=gsvelto,florian

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/d892a888fe9c
https://hg.mozilla.org/mozilla-central/rev/2ea5ccb8f3a1

Comment 10

[Narcis Beleuzu [:NarcisB]]

Backed out for toolchain bustages on UniquePtrExtensions.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/56834c5fc9390da3bdfb41a3fe3f06119fbb3502
Push link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=a8518ea4b5944cd5563a882c27b304fc82d07dba&selectedJob=253975140
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=253975140&repo=autoland&lineNumber=922

Comment 11

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

See bug 1534780 comment #9.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f936472f7576
Delete file_util from ex-Chromium IPC source. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/87737e44c8b7
Remove references to the old Chromium temporary file prefix. r=gsvelto,florian

Comment 13

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f936472f7576
https://hg.mozilla.org/mozilla-central/rev/87737e44c8b7