Closed
Bug 1426528
Opened 6 years ago
Closed 6 years ago
Stop staging BRANDING_FILES
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: tomprince, Assigned: tomprince)
Details
Attachments
(3 files)
https://dxr.mozilla.org/mozilla-central/rev/1624b88874765bf57e9feba176d30149c748d9d2/browser/app/Makefile.in#91-92 appears to be the only place where dist/branding is used, everywhere else has been switched to using MOZ_BRANDING_DIR directly. So, we can remove that one reference and get rid of the code used to support that.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 3•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8938176 [details] Bug 1426528: Install macOS icons from MOZ_BRANDING_DIR directly; https://reviewboard.mozilla.org/r/208912/#review214622 [L10N try results](https://treeherder.mozilla.org/#/jobs?repo=try&revision=aaacfde32580f8a2e4a34c17186b465fee92ce6a)
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 6•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8938176 [details] Bug 1426528: Install macOS icons from MOZ_BRANDING_DIR directly; https://reviewboard.mozilla.org/r/208912/#review214646 It looks like `make_dmg` hard-codes using `dist/branding`. I'll have to copy over the logic in `unpack_dmg` that accepts these paths as arguments.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 10•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8938176 [details] Bug 1426528: Install macOS icons from MOZ_BRANDING_DIR directly; https://reviewboard.mozilla.org/r/208914/#review215172
Attachment #8938176 -
Flags: review+
|
|
||
Comment 11•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8938602 [details] Bug 1426528: Pass paths to extra dmg files explicitly when packing; https://reviewboard.mozilla.org/r/209234/#review215174
Attachment #8938602 -
Flags: review+
|
|
||
Comment 12•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8938177 [details] Bug 1426528: Get rid of support for BRANDING_FILES in `moz.build`; https://reviewboard.mozilla.org/r/208916/#review215176 \o/
Attachment #8938177 -
Flags: review+
|
|
||
Updated•6 years ago
|
Attachment #8938176 -
Flags: review?(core-build-config-reviews)
Attachment #8938602 -
Flags: review?(core-build-config-reviews)
Attachment #8938177 -
Flags: review?(core-build-config-reviews)
|
||
Comment 13•6 years ago
|
||
Pushed by mozilla@hocat.ca: https://hg.mozilla.org/integration/autoland/rev/b0f9b612103c Install macOS icons from MOZ_BRANDING_DIR directly; r=glandium https://hg.mozilla.org/integration/autoland/rev/deea080fb727 Pass paths to extra dmg files explicitly when packing; r=glandium https://hg.mozilla.org/integration/autoland/rev/6630994fe2bb Get rid of support for BRANDING_FILES in `moz.build`; r=glandium
|
||
Comment 14•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b0f9b612103c https://hg.mozilla.org/mozilla-central/rev/deea080fb727 https://hg.mozilla.org/mozilla-central/rev/6630994fe2bb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•