1426555 - Move --enable-stdcxx-compat to python configure

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1426555 - Make autospider builds use --enable-stdcxx-compat on Linux only.

Some of the variants are multi-platforms, and having
--enable-stdcxx-compat in their definition will break when the option is
moved over to python configure.

Review commit: https://reviewboard.mozilla.org/r/208980/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208980/

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1426555 - Use mozconfig.no-compile in non-compiling android jobs.

Instead of manually unsetting a few variables and adding
--disable-compile-environment, we can rely on the mozconfig that does
all that.

Review commit: https://reviewboard.mozilla.org/r/208982/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208982/

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1426555 - Allow to add host compiler flags from python configure.

Bug 1325632 added some facility to add target compiler flags. This
change extends it to add allow adding host compiler flags as well.

Review commit: https://reviewboard.mozilla.org/r/208984/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208984/

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1426555 - Move --enable-stdcxx-compat to python configure.

At the same time, we make it actually do something on spidermonkey
builds. We also add an environment variable alternative, that we use
in mozconfig.stdcxx, allowing for mozconfig.no-compile to override it
and avoid configure failures on e.g. artifact builds.

Review commit: https://reviewboard.mozilla.org/r/208986/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208986/

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8938219 [details]
Bug 1426555 - Make autospider builds use --enable-stdcxx-compat on Linux only.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/208980/diff/1-2/

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8938220 [details]
Bug 1426555 - Use mozconfig.no-compile in non-compiling android jobs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/208982/diff/1-2/

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8938221 [details]
Bug 1426555 - Allow to add host compiler flags from python configure.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/208984/diff/1-2/

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 8938222 [details]
Bug 1426555 - Move --enable-stdcxx-compat to python configure.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/208986/diff/1-2/

Comment 9

[Mike Hommey [:glandium]]

Comment on attachment 8938222 [details]
Bug 1426555 - Move --enable-stdcxx-compat to python configure.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/208986/diff/2-3/

Comment 10

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8938219 [details]
Bug 1426555 - Make autospider builds use --enable-stdcxx-compat on Linux only.

https://reviewboard.mozilla.org/r/208980/#review214684

I never did bother to learn what that option was all about, but your change definitely seems good.

Comment 11

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8938220 [details]
Bug 1426555 - Use mozconfig.no-compile in non-compiling android jobs.

https://reviewboard.mozilla.org/r/208982/#review215024

Comment 12

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8938221 [details]
Bug 1426555 - Allow to add host compiler flags from python configure.

https://reviewboard.mozilla.org/r/208984/#review215026

Comment 13

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8938222 [details]
Bug 1426555 - Move --enable-stdcxx-compat to python configure.

https://reviewboard.mozilla.org/r/208986/#review215028

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0052f68e4f79
Make autospider builds use --enable-stdcxx-compat on Linux only. r=sfink
https://hg.mozilla.org/integration/autoland/rev/91dc62bd6c43
Use mozconfig.no-compile in non-compiling android jobs. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/9dd726d081e0
Allow to add host compiler flags from python configure. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/81b25e99112c
Move --enable-stdcxx-compat to python configure. r=chmanchester

Comment 15

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0052f68e4f79
https://hg.mozilla.org/mozilla-central/rev/91dc62bd6c43
https://hg.mozilla.org/mozilla-central/rev/9dd726d081e0
https://hg.mozilla.org/mozilla-central/rev/81b25e99112c

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/19ba0c25cd49
Keep build files in sync (Port bug 1426555: Move --enable-stdcxx-compat to python configure). rs=bustage-fix

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fb4b9040b9f3
Get rid of build configuration from l10n mozconfigs (followup to bug 1426555); r=me