Closed Bug 1426559 Opened 2 years ago Closed 2 years ago

browser_windowopen_flicker.js is going to permafail on DevEdition builds when Gecko 59 merges to Beta on 2018-01-11

Categories

(Firefox :: General, defect, critical)

defect
Not set
critical

Tracking

()

VERIFIED FIXED
Firefox 59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 + verified

People

(Reporter: RyanVM, Assigned: florian)

References

Details

Attachments

(1 file, 1 obsolete file)

[Tracking Requested - why for this release]: Permafailing test on the next merge day.

Per IRC discussion, this appears to be a legit flickering issue in DevEdition being caught by the test \m/

https://treeherder.mozilla.org/logviewer.html#?job_id=152747634&repo=try

TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_windowopen_flicker.js | unexpected changed rect: ({x1:78, x2:91, y1:46, y2:59, w:13, h:13}), window width: 1280
TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_windowopen_flicker.js | unexpected changed rect: ({x1:110, x2:124, y1:46, y2:59, w:14, h:13}), window width: 1280
TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_windowopen_flicker.js | should have 0 unknown flickering areas - Got 2, expected 0
Flags: needinfo?(florian)
Tracking for 59, so that we'll remember to follow up in January before the merge.
Fun fact, I've been playing around with getting browser_startup_flicker.js running on DevEdition builds as well and it also fails with what I suspect are real failures :)

https://treeherder.mozilla.org/logviewer.html#?job_id=153063831&repo=try

216 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_flicker.js | unexpected changed rect: ({x1:78, x2:91, y1:54, y2:67, w:13, h:13}), window width: 1280

I intend to file a bug shortly for enabling this test on DevEdition builds, so let's use this bug to track fixing the real issues found with them.
Summary: browser_windowopen_flicker.js is going to permafail on DevEdition builds when Gecko 59 merges to Beta on 2018-01-11 → browser_startup_flicker.js and browser_windowopen_flicker.js are going to permafail on DevEdition builds when Gecko 59 merges to Beta on 2018-01-11
Attached patch Fix (obsolete) — Splinter Review
This changes the exception lists. The reload button flickers at a different place on new windows because the devtools icon is in the toolbar. And at startup the devtools icon flickers (I'll file a bug for this and include the bug number in the exception if this patch is enough to get the tests to pass).
Attachment #8939965 - Flags: review?(jhofmann)
Assignee: nobody → florian
Status: NEW → ASSIGNED
Ryan, I only tested this patch on a local OS X build with ac_add_options --with-branding=browser/branding/aurora, before checking this in we should test on try on all desktop platforms to verify that the whitelist entries match all cases.
Flags: needinfo?(florian) → needinfo?(ryanvm)
Comment on attachment 8939965 [details] [diff] [review]
Fix

Review of attachment 8939965 [details] [diff] [review]:
-----------------------------------------------------------------

Seems good, assuming it passes on try. :)

::: browser/base/content/test/performance/browser_windowopen_flicker.js
@@ +109,5 @@
>          {name: "bug 1421463 - reload toolbar icon shouldn't flicker",
>           condition: r => r.h == 13 && inRange(r.w, 14, 16) && // icon size
>                           inRange(r.y1, 40, 80) && // in the toolbar
>                           // near the left side of the screen
> +                         AppConstants.MOZ_DEV_EDITION ? inRange(r.x1, 100, 120) :

A short comment would be helpful here.
Attachment #8939965 - Flags: review?(jhofmann) → review+
Depends on: 1428191
Attached patch Fix v2Splinter Review
Added a comment, and filed bug 1428191 to mention the number in the other comment.
Attachment #8939965 - Attachment is obsolete: true
Comment on attachment 8939987 [details] [diff] [review]
Fix v2

Looks like this was enough to make browser_windowopen_flicker.js happy, but browser_startup_flicker.js is still failing on all platforms.

https://treeherder.mozilla.org/logviewer.html#?job_id=154258096&repo=try
https://treeherder.mozilla.org/logviewer.html#?job_id=154257691&repo=try
https://treeherder.mozilla.org/logviewer.html#?job_id=154250785&repo=try

No Windows results yet, but based on our IRC discussion, it sounds like you already have an idea of what's going on.
Flags: needinfo?(ryanvm)
Attachment #8939987 - Flags: feedback-
Per IRC discussion with Florian, I'm going to repurpose this bug for just browser_windowopen_flicker.js and land that part of the patch now. Bug 1428191 will track the ongoing issues with browser_startup_flicker.js.
Summary: browser_startup_flicker.js and browser_windowopen_flicker.js are going to permafail on DevEdition builds when Gecko 59 merges to Beta on 2018-01-11 → browser_windowopen_flicker.js is going to permafail on DevEdition builds when Gecko 59 merges to Beta on 2018-01-11
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a21215c2f64
Fix browser_windowopen_flicker.js to pass on DevEdition builds. r=johannh
https://hg.mozilla.org/mozilla-central/rev/2a21215c2f64
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.