Closed Bug 1426578 Opened 2 years ago Closed 2 years ago

Offload MediaCacheStream::Init/InitAsClone to another thread

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(5 files)

We are almost there! Only a few functions left that need to be moved to a non-main thread.
Assignee: nobody → jwwang
Blocks: 1369263
Priority: -- → P3
Attachment #8938241 - Flags: review?(bechen)
Attachment #8938242 - Flags: review?(bechen)
Attachment #8938243 - Flags: review?(bechen)
Attachment #8938244 - Flags: review?(bechen)
Attachment #8938245 - Flags: review?(bechen)
Comment on attachment 8938241 [details]
Bug 1426578. P1 - tweak the constructor and init functions of ChannelMediaResource/MediaCacheStream.

https://reviewboard.mozilla.org/r/208990/#review214680
Attachment #8938241 - Flags: review?(bechen) → review+
Comment on attachment 8938242 [details]
Bug 1426578. P2 - always access MediaCache::mStreams while the cache monitor is held.

https://reviewboard.mozilla.org/r/208992/#review214688
Attachment #8938242 - Flags: review?(bechen) → review+
Comment on attachment 8938244 [details]
Bug 1426578. P4 - offload InitAsClone() to another thread.

https://reviewboard.mozilla.org/r/208996/#review214730
Attachment #8938244 - Flags: review?(bechen) → review+
Comment on attachment 8938243 [details]
Bug 1426578. P3 - make MediaCacheStream::InitAsClone() infallible.

https://reviewboard.mozilla.org/r/208994/#review214732
Attachment #8938243 - Flags: review?(bechen) → review+
Comment on attachment 8938245 [details]
Bug 1426578. P5 - offload Init() to another thread.

https://reviewboard.mozilla.org/r/208998/#review214734
Attachment #8938245 - Flags: review?(bechen) → review+
Attachment #8938241 - Flags: review?(gsquelart)
Attachment #8938242 - Flags: review?(gsquelart)
Attachment #8938243 - Flags: review?(gsquelart)
Attachment #8938244 - Flags: review?(gsquelart)
Attachment #8938245 - Flags: review?(gsquelart)
Comment on attachment 8938241 [details]
Bug 1426578. P1 - tweak the constructor and init functions of ChannelMediaResource/MediaCacheStream.

https://reviewboard.mozilla.org/r/208990/#review214770
Attachment #8938241 - Flags: review?(gsquelart) → review+
Comment on attachment 8938242 [details]
Bug 1426578. P2 - always access MediaCache::mStreams while the cache monitor is held.

https://reviewboard.mozilla.org/r/208992/#review214772
Attachment #8938242 - Flags: review?(gsquelart) → review+
Comment on attachment 8938243 [details]
Bug 1426578. P3 - make MediaCacheStream::InitAsClone() infallible.

https://reviewboard.mozilla.org/r/208994/#review214774
Attachment #8938243 - Flags: review?(gsquelart) → review+
Comment on attachment 8938244 [details]
Bug 1426578. P4 - offload InitAsClone() to another thread.

https://reviewboard.mozilla.org/r/208996/#review214776
Attachment #8938244 - Flags: review?(gsquelart) → review+
Comment on attachment 8938245 [details]
Bug 1426578. P5 - offload Init() to another thread.

https://reviewboard.mozilla.org/r/208998/#review214778
Attachment #8938245 - Flags: review?(gsquelart) → review+
Thanks for the reviews!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a29b9105722b
P1 - tweak the constructor and init functions of ChannelMediaResource/MediaCacheStream. r=bechen,gerald
https://hg.mozilla.org/integration/autoland/rev/fb2edb2d8dd1
P2 - always access MediaCache::mStreams while the cache monitor is held. r=bechen,gerald
https://hg.mozilla.org/integration/autoland/rev/1f6caf89e382
P3 - make MediaCacheStream::InitAsClone() infallible. r=bechen,gerald
https://hg.mozilla.org/integration/autoland/rev/d005226af73b
P4 - offload InitAsClone() to another thread. r=bechen,gerald
https://hg.mozilla.org/integration/autoland/rev/46879b2506ca
P5 - offload Init() to another thread. r=bechen,gerald
You need to log in before you can comment on or make changes to this bug.