Closed Bug 1426674 Opened 2 years ago Closed 2 years ago

Speed up DAMP by not pre-running firefox on the new profile

Categories

(Testing :: Talos, enhancement)

enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

(Whiteboard: [PI:January])

Attachments

(1 file)

Here:
https://searchfox.org/mozilla-central/source/testing/talos/talos/ffsetup.py#200-201
We run Firefox once, before running the tests.
This step is very slow. Firefox stays open for quite a bit and it drastically slow down iteration when working on DAMP or any DAMP test script.

I'm trying to suggest everyone in DevTools to engage with DAMP and contribute to test scripts, but `./mach talos-test --activeTests damp` is very slow to startup, everytime. bug 1409046 is another way to speed it up.

I would like to suggest simply not pre-running Firefox as it doesn't seem to really affect DAMP results:
https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=mozilla-central&newProject=try&newRevision=638f8f1b68034c222702b903ff245493aaf84234&originalSignature=edaec66500db21d37602c99daa61ac983f21a6ac&newSignature=edaec66500db21d37602c99daa61ac983f21a6ac&showOnlyConfident=1&framework=1&selectedTimeRange=172800
  "close" tests are known to be flaky and aren't very important.
  So I would say it is worth the trade for a few seconds faster to run.
this is a great idea- we would have to find a way to do this either locally, or conditionally for damp only.  adding this to the list to look at in January- although we have a lot of high priority stuff in January, so this might get bumped a bit.  I really think fixing the venv stuff would be an overall win, although I think that is a few days of work.
Whiteboard: [PI:January]
As for bug 1409046, I'm willing to contribute if that's not too complex.

Do you think this patch is ok or should I do something more generic, involving DAMP manifest?
Comment on attachment 8938429 [details]
Bug 1426674 - Disable profile pre-run for DAMP.

https://reviewboard.mozilla.org/r/209136/#review214894

oh, this is real simple- and addresses all my concerns!  thanks for putting this together
Attachment #8938429 - Flags: review?(jmaher) → review+
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b5b951c9a615
Disable profile pre-run for DAMP. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/b5b951c9a615
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Assignee: nobody → poirot.alex
You need to log in before you can comment on or make changes to this bug.