1426728 - Crash in AutoPointerEventTargetUpdater::AutoPointerEventTargetUpdater

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P2)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is
report bp-ffeadcc0-f062-4315-a692-d0ca80171221.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll AutoPointerEventTargetUpdater::AutoPointerEventTargetUpdater layout/base/PresShell.cpp:572
1 xul.dll mozilla::PresShell::HandleEventWithTarget layout/base/PresShell.cpp:7585
2 xul.dll mozilla::PointerEventHandler::DispatchPointerFromMouseOrTouch dom/events/PointerEventHandler.cpp:584
3 xul.dll mozilla::PresShell::HandleEvent layout/base/PresShell.cpp:7366
4 xul.dll nsViewManager::DispatchEvent view/nsViewManager.cpp:812
5 xul.dll nsView::HandleEvent view/nsView.cpp:1140
6 xul.dll mozilla::widget::PuppetWidget::DispatchEvent widget/PuppetWidget.cpp:409
7 xul.dll mozilla::layers::APZCCallbackHelper::DispatchWidgetEvent gfx/layers/apz/util/APZCCallbackHelper.cpp:499
8 xul.dll mozilla::dom::TabChild::RecvRealTouchEvent dom/ipc/TabChild.cpp:1976
9 xul.dll mozilla::dom::PBrowserChild::OnMessageReceived ipc/ipdl/PBrowserChild.cpp:3804

=============================================================

There are 2 crashes in nightly 59 starting with buildid 20171220121833. In analyzing the backtrace, the regression may have been introduced by patch [1].

[1]

Comment 1

[Calixte Denizet (:calixte)]

Forgot the changeset link:
[1] https://hg.mozilla.org/mozilla-central/rev/ce9b2476de5d

Comment 2

[Ming-Chou Shih [:stone]]

Attachment: Don't cache the event target of pointer events when they are generated from touch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a0e6c49e344437c4319c91171ace5248e8bc639

Comment 3

[Ming-Chou Shih [:stone]]

Comment on attachment 8938699 [details] [diff] [review]
Don't cache the event target of pointer events when they are generated from touch

We cache the event target because we have to dispatch the mouse event to the same target as its corresponding pointer event. We don't need to do the same thing for touch events.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8938699 [details] [diff] [review]
Don't cache the event target of pointer events when they are generated from touch

I assume this gives the same behavior as what other browsers have with touch + pointer.

Good to get rid of that unused param of HandleEvent.

Comment 5

[Ming-Chou Shih [:stone]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a0e6c49e344437c4319c91171ace5248e8bc639

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/786c0c3f6975
Don't cache the event target of pointer events when they are generated from touch. r=smaug.

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/786c0c3f6975