1426745 - [jsdbg2] Debugger tutorial for trapping 'debugger' statements is broken

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Jim Blandy :jimb]

The tutorial in js/src/doc/Debugger/Tutorial-Debugger-Statement.md no longer works with current Firefoxen, and hasn't since E10S was enabled by default.

Comment 1

[Jim Blandy :jimb]

Attachment: Documentation fixes to js/src/doc/README.md.

Comment 2

[Jim Blandy :jimb]

Attachment: Documentation fixes to js/src/doc/lib/make-bibliography.sh.

Comment 3

[Jim Blandy :jimb]

Attachment: js/src/doc: Move http operations into their own file, and update for new 'curl' behavior.

Comment 4

[Jim Blandy :jimb]

Attachment: New Debugger API Tutorial, replacing old tutorial broken by e10s.

This tutorial has been play-tested by Mossop and declared "pretty good". :)

Comment 5

[Jason Orendorff [:jorendorff]]

Comment on attachment 8938485 [details] [diff] [review]
Documentation fixes to js/src/doc/README.md.

Review of attachment 8938485 [details] [diff] [review]:
-----------------------------------------------------------------

I'm just going to stamp all these. Documentation is good.

Comment 6

[Jason Orendorff [:jorendorff]]

Comment on attachment 8938488 [details] [diff] [review]
js/src/doc: Move http operations into their own file, and update for new 'curl' behavior.

Review of attachment 8938488 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/doc/lib/http.sh
@@ +7,5 @@
> +http_get() {
> +    curl --silent -XGET "$1"                                    \
> +         -H"Cache-Control: no-cache, no-store, must-revalidate" \
> +         -H"Pragma: no-cache"                                   \
> +         -H"Expires: 0"

Pre-existing, but I think "Expires" is meaningless on a request, it's for responses only. Same for "Cache-Control: must-revalidate".

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jimb, could you have a look please?

Comment 8

[Jim Blandy :jimb]

Some of these don't matter any more, since the new MDN doesn't support API keys any more. But the doc fixes are still valid. I'll get them landed.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3421ec294e24
New Debugger API Tutorial, replacing old tutorial broken by e10s. DONTBUILD r=jorendorff

Comment 10

[Jim Blandy :jimb]

I've updated the MDN pages, and pushed "New Debugger API Tutorial, replacing old tutorial broken by e10s." to inbound. The rest of the patches don't need to land. I'll let the bot close this bug once the changeset makes it to M-C.

Comment 11

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/3421ec294e24