Closed Bug 1426745 Opened 2 years ago Closed 8 months ago

[jsdbg2] Debugger tutorial for trapping 'debugger' statements is broken

Categories

(Core :: JavaScript Engine, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: jimb, Assigned: jimb)

Details

Attachments

(4 files)

The tutorial in js/src/doc/Debugger/Tutorial-Debugger-Statement.md no longer works with current Firefoxen, and hasn't since E10S was enabled by default.
Attachment #8938485 - Flags: review?(jorendorff)
This tutorial has been play-tested by Mossop and declared "pretty good". :)
Attachment #8938489 - Flags: review?(jorendorff)
Priority: -- → P2
Comment on attachment 8938485 [details] [diff] [review]
Documentation fixes to js/src/doc/README.md.

Review of attachment 8938485 [details] [diff] [review]:
-----------------------------------------------------------------

I'm just going to stamp all these. Documentation is good.
Attachment #8938485 - Flags: review?(jorendorff) → review+
Attachment #8938487 - Flags: review?(jorendorff) → review+
Comment on attachment 8938488 [details] [diff] [review]
js/src/doc: Move http operations into their own file, and update for new 'curl' behavior.

Review of attachment 8938488 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/doc/lib/http.sh
@@ +7,5 @@
> +http_get() {
> +    curl --silent -XGET "$1"                                    \
> +         -H"Cache-Control: no-cache, no-store, must-revalidate" \
> +         -H"Pragma: no-cache"                                   \
> +         -H"Expires: 0"

Pre-existing, but I think "Expires" is meaningless on a request, it's for responses only. Same for "Cache-Control: must-revalidate".
Attachment #8938488 - Flags: review?(jorendorff) → review+
Attachment #8938489 - Flags: review?(jorendorff) → review+

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jimb, could you have a look please?

Flags: needinfo?(jimb)

Some of these don't matter any more, since the new MDN doesn't support API keys any more. But the doc fixes are still valid. I'll get them landed.

Flags: needinfo?(jimb)
Pushed by jblandy@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3421ec294e24
New Debugger API Tutorial, replacing old tutorial broken by e10s. DONTBUILD r=jorendorff

I've updated the MDN pages, and pushed "New Debugger API Tutorial, replacing old tutorial broken by e10s." to inbound. The rest of the patches don't need to land. I'll let the bot close this bug once the changeset makes it to M-C.

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.