|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
The patch below should suffice to reproduce locally: https://hg.mozilla.org/try/rev/0154852baa88e427a1957e67ec1fd9d3e0acd80b https://treeherder.mozilla.org/logviewer.html#?job_id=153041902&repo=try /builds/worker/workspace/build/src/xpcom/threads/nsThreadUtils.cpp:43:32: error: 'mName' was not declared in this scope /builds/worker/workspace/build/src/xpcom/threads/nsThreadUtils.cpp:44:33: error: 'mName' was not declared in this scope
nsThreadUtils.cpp needs something like this: #ifdef RELEASE_OR_BETA NS_IMPL_ISUPPORTS(Runnable, nsIRunnable, nsINamed) #else NS_IMPL_NAMED_ADDREF(Runnable, mName) NS_IMPL_NAMED_RELEASE(Runnable, mName) NS_IMPL_QUERY_INTERFACE(Runnable, nsIRunnable, nsINamed) #endif Though I think a similar guard will also be needed on the Runnable guard in nsISupportsImpl.h or we will get slightly less good leak information on beta. That's not a big deal, I think...
Noting that this blocks the upcoming merge of 59 to beta. Andrew are you taking this on?
tracking-firefox59: ? → blocking
Assignee: nobody → continuation
Comment on attachment 8939968 [details] Bug 1426779 - Disable precise runnable leakchecking names on release and beta. https://reviewboard.mozilla.org/r/210242/#review215966 I thought we landed a patch like this already...did it get reverted accidentally, or am I just thinking of something different?
Attachment #8939968 - Flags: review?(nfroyd) → review+
(In reply to Nathan Froyd [:froydnj] from comment #4) > I thought we landed a patch like this already...did it get reverted > accidentally, or am I just thinking of something different? There have been a lot of patches to fix up mName missing on beta breakage...
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/2db2c61d036c Disable precise runnable leakchecking names on release and beta. r=froydnj
Status: NEW → RESOLVED
Last Resolved: 12 days ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Status: RESOLVED → VERIFIED
status-firefox59: fixed → verified
You need to log in before you can comment on or make changes to this bug.