1426779 - Debug and DevEdition builds are going to permafail when Gecko 59 merges to Beta on 2018-01-11

Status: VERIFIED FIXED

(Core :: XPCOM, defect, P1)

Description

[Ryan VanderMeulen [:RyanVM]]

The patch below should suffice to reproduce locally:
https://hg.mozilla.org/try/rev/0154852baa88e427a1957e67ec1fd9d3e0acd80b

https://treeherder.mozilla.org/logviewer.html#?job_id=153041902&repo=try

/builds/worker/workspace/build/src/xpcom/threads/nsThreadUtils.cpp:43:32: error: 'mName' was not declared in this scope
/builds/worker/workspace/build/src/xpcom/threads/nsThreadUtils.cpp:44:33: error: 'mName' was not declared in this scope

Comment 1

[Andrew McCreight [:mccr8]]

nsThreadUtils.cpp needs something like this:

#ifdef RELEASE_OR_BETA
NS_IMPL_ISUPPORTS(Runnable, nsIRunnable, nsINamed)
#else
NS_IMPL_NAMED_ADDREF(Runnable, mName)
NS_IMPL_NAMED_RELEASE(Runnable, mName)
NS_IMPL_QUERY_INTERFACE(Runnable, nsIRunnable, nsINamed)
#endif

Though I think a similar guard will also be needed on the Runnable guard in nsISupportsImpl.h or we will get slightly less good leak information on beta. That's not a big deal, I think...

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Noting that this blocks the upcoming merge of 59 to beta. Andrew are you taking this on?

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1426779 - Disable precise runnable leakchecking names on release and beta.

The NS_IMPL_NAMED_* macros rely on the mName field, which are not
defined on beta or release, so don't use them on those branches, so
that Firefox will build.

Review commit: https://reviewboard.mozilla.org/r/210242/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210242/

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8939968 [details]
Bug 1426779 - Disable precise runnable leakchecking names on release and beta.

https://reviewboard.mozilla.org/r/210242/#review215966

I thought we landed a patch like this already...did it get reverted accidentally, or am I just thinking of something different?

Comment 5

[Andrew McCreight [:mccr8]]

(In reply to Nathan Froyd [:froydnj] from comment #4)
> I thought we landed a patch like this already...did it get reverted
> accidentally, or am I just thinking of something different?

There have been a lot of patches to fix up mName missing on beta breakage...

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2db2c61d036c
Disable precise runnable leakchecking names on release and beta. r=froydnj

Comment 7

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/2db2c61d036c