Debug and DevEdition builds are going to permafail when Gecko 59 merges to Beta on 2018-01-11

VERIFIED FIXED in Firefox 59

Status

()

Core
XPCOM
P1
blocker
VERIFIED FIXED
27 days ago
11 days ago

People

(Reporter: RyanVM, Assigned: mccr8)

Tracking

Trunk
mozilla59
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox57 unaffected, firefox58 unaffected, firefox59blocking verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

27 days ago
The patch below should suffice to reproduce locally:
https://hg.mozilla.org/try/rev/0154852baa88e427a1957e67ec1fd9d3e0acd80b

https://treeherder.mozilla.org/logviewer.html#?job_id=153041902&repo=try

/builds/worker/workspace/build/src/xpcom/threads/nsThreadUtils.cpp:43:32: error: 'mName' was not declared in this scope
/builds/worker/workspace/build/src/xpcom/threads/nsThreadUtils.cpp:44:33: error: 'mName' was not declared in this scope
Flags: needinfo?(continuation)
(Assignee)

Comment 1

27 days ago
nsThreadUtils.cpp needs something like this:

#ifdef RELEASE_OR_BETA
NS_IMPL_ISUPPORTS(Runnable, nsIRunnable, nsINamed)
#else
NS_IMPL_NAMED_ADDREF(Runnable, mName)
NS_IMPL_NAMED_RELEASE(Runnable, mName)
NS_IMPL_QUERY_INTERFACE(Runnable, nsIRunnable, nsINamed)
#endif

Though I think a similar guard will also be needed on the Runnable guard in nsISupportsImpl.h or we will get slightly less good leak information on beta. That's not a big deal, I think...
Noting that this blocks the upcoming merge of 59 to beta. Andrew are you taking this on?
tracking-firefox59: ? → blocking
(Assignee)

Updated

13 days ago
Assignee: nobody → continuation
Flags: needinfo?(continuation)
Comment hidden (mozreview-request)

Comment 4

13 days ago
mozreview-review
Comment on attachment 8939968 [details]
Bug 1426779 - Disable precise runnable leakchecking names on release and beta.

https://reviewboard.mozilla.org/r/210242/#review215966

I thought we landed a patch like this already...did it get reverted accidentally, or am I just thinking of something different?
Attachment #8939968 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 5

13 days ago
(In reply to Nathan Froyd [:froydnj] from comment #4)
> I thought we landed a patch like this already...did it get reverted
> accidentally, or am I just thinking of something different?

There have been a lot of patches to fix up mName missing on beta breakage...

Comment 6

13 days ago
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2db2c61d036c
Disable precise runnable leakchecking names on release and beta. r=froydnj

Comment 7

12 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2db2c61d036c
Status: NEW → RESOLVED
Last Resolved: 12 days ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
(Reporter)

Updated

11 days ago
Status: RESOLVED → VERIFIED
status-firefox59: fixed → verified
You need to log in before you can comment on or make changes to this bug.