Crash in mozilla::a11y::NotificationController::WillRefresh

VERIFIED FIXED in Firefox 59

Status

()

Core
Disability Access APIs
--
critical
VERIFIED FIXED
26 days ago
14 days ago

People

(Reporter: calixte, Assigned: Samuel Thibault)

Tracking

(Blocks: 1 bug, {crash, regression})

59 Branch
mozilla59
Unspecified
Windows 10
crash, regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox57 unaffected, firefox58 unaffected, firefox59 verified)

Details

(Whiteboard: [clouseau], crash signature)

Attachments

(1 attachment)

(Reporter)

Description

26 days ago
This bug was filed from the Socorro interface and is
report bp-17a3c98c-594f-4333-88fe-a4a1e0171222.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll mozilla::a11y::NotificationController::WillRefresh accessible/base/NotificationController.cpp:645
1 xul.dll nsRefreshDriver::Tick layout/base/nsRefreshDriver.cpp:1862
2 xul.dll nsRefreshDriver::DoTick layout/base/nsRefreshDriver.cpp:1484
3 xul.dll nsRefreshDriver::DoRefresh layout/base/nsRefreshDriver.cpp:2316
4 xul.dll nsRefreshDriver::FinishedWaitingForTransaction layout/base/nsRefreshDriver.cpp:2154
5 xul.dll nsRefreshDriver::NotifyTransactionCompleted layout/base/nsRefreshDriver.cpp:2221
6 xul.dll mozilla::layers::ClientLayerManager::DidComposite gfx/layers/client/ClientLayerManager.cpp:520
7 xul.dll mozilla::dom::TabChild::DidComposite dom/ipc/TabChild.cpp:3230
8 xul.dll mozilla::layers::CompositorBridgeChild::RecvDidComposite gfx/layers/ipc/CompositorBridgeChild.cpp:547
9 xul.dll mozilla::layers::PCompositorBridgeChild::OnMessageReceived ipc/ipdl/PCompositorBridgeChild.cpp:1441

=============================================================

There are 14 crashes in nightly 59 with buildid 20171222100407. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1425932.

[1] https://hg.mozilla.org/mozilla-central/rev/09e57c36e8da
Flags: needinfo?(samuel.thibault)

Comment 1

26 days ago
Samuel, could it be that parent's WillRefresh kills the child document?
(Assignee)

Comment 2

25 days ago
Created attachment 8938755 [details] [diff] [review]
fix

Oh, that can be, indeed, here is a fix.
Flags: needinfo?(samuel.thibault)
Attachment #8938755 - Flags: review?(surkov.alexander)

Updated

21 days ago
Attachment #8938755 - Flags: review?(surkov.alexander) → review+

Updated

21 days ago
Keywords: checkin-needed

Comment 3

20 days ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cdac2f62179
Check that child document still exists after parent processing r=surkov
Keywords: checkin-needed

Comment 4

20 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4cdac2f62179
Status: NEW → RESOLVED
Last Resolved: 20 days ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
(Reporter)

Comment 5

14 days ago
No more crashes after the patch landed.
Assignee: nobody → samuel.thibault
Status: RESOLVED → VERIFIED
status-firefox59: fixed → verified
You need to log in before you can comment on or make changes to this bug.