1426920 - Duplicate vertical scroll bar in the Response tab

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[magicp]

Attachment: duplicate-vertical-scrollbar-in-response-tab.png

Steps to reproduce:
1. Launch Nightly
2. Open Netmonitor (Ctrl+Shift+E)
3. Set "CSS" requests list filter
4. Go to https://bugzilla.mozilla.org
5. Select "global.css"
6. Switch sidebar tab to "Response"

Actual results:
Duplicate vertical scroll bar. Particularly it is difficult to scroll because overlap them on Mac.

Expected results:
No duplicate.

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e16b6746b48f5a673888b4958ed3cb9192f7b1ab&tochange=cbf0cc9cb0b5ea2724e1b0586523ce6a275a991e

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Ricky, could bug Bug 1350226 cause this regression?

Honza

Comment 2

[Ricky Chien [:rickychien] (inactive)]

I believe this is a regression after we merged preview tab into response panel. The editor-row-container should occupy the available vertical space as usual. Patch will be updated soon.

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1426920 - Netmonitor ResponsePanel's editor-row-container should occupy the available vertical space

Review commit: https://reviewboard.mozilla.org/r/210360/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210360/

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8940080 [details]
Bug 1426920 - Netmonitor ResponsePanel's editor-row-container should occupy the available vertical space

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210360/diff/1-2/

Comment 5

[[e-mail]]

Comment on attachment 8940080 [details]
Bug 1426920 - Netmonitor ResponsePanel's editor-row-container should occupy the available vertical space

https://reviewboard.mozilla.org/r/210360/#review216112

The result looks right in response panel now, thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b85f17608702
Netmonitor ResponsePanel's editor-row-container should occupy the available vertical space r=gasolin

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/b85f17608702

Comment 8

[magicp]

Attachment: after-bug-fix.mp4

After bug fix, horizontal scrollbar does not appear until scroll to bottom. Please find expected.png

Comment 9

[magicp]

Attachment: expected.png

Comment 10

[Ricky Chien [:rickychien] (inactive)]

Oh, thanks for the delicate check. I'll file a new bug to address this issue.

Comment 11

[Gerry Chang [:gchang]]

It's too late for 58, mark 58 won't fix.

Comment 12

[Sajedul Islam]

I have reproduced this bug with Nightly 59.0a1 (2017-12-23) on Windows 10 , 64 Bit ! 

This bug's fix is Verified with latest Beta !

Build   ID    20180215111455
User Agent    Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0

Comment 13

[Oana Botisan, Desktop QA]

I verified the fix on Ubuntu 16.04 x64 and on macOS 10.13 using the latest Nightly 60.0a1 and beta 59.0b11, too. The issue is not reproducing anymore.

According to this result and the one from comment 12, I will mark this bug as verified fixed.