1427000 - Bring back spaces on the Mac .app

Status: NEW

(Toolkit :: Application Update, enhancement, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

As part of the bug 1378834, Glandium suggested that we add spaces in the .app name: https://bugzilla.mozilla.org/show_bug.cgi?id=1407285#c14

In bug 1423856, the first time it landed, it seems that it caused some issues.
So, i did a backout of the patch:
https://hg.mozilla.org/mozilla-central/rev/c25a7460cbeb5021a1e4913efa8b500bcfb462ab

Now, because OSX nightly were broken for a different reason ( https://bugzilla.mozilla.org/show_bug.cgi?id=1423856#c34 ), I am not sure it was the same issue. We should figure out what would be require to test that.

Comment 1

[Adrian Florinescu [:aflorinescu]]

OsX 10.12 / OsX 10.13
Firefox 59.0a1 2018-01-02

To note for this bug that the Applications and Dock show FirefoxNightly.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/projects/oak/rev/ca92c1d86aadc41edcfdb43bd367722b7a0be29a
Bug 1427000 - Add spaces in the .app - Try to land on the oak branch to test the nightly builds/updates

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Adrian, could you please double check this bug for me on oak?

Downloading http://ftp.mozilla.org/pub/firefox/nightly/latest-oak/firefox-57.0a1.en-US.mac.dmg and try to update.
On my system, the update works even if the application is still called Nightly on the system.
Doing the same with 58 on oak (which has probably the patch) works fine with spaces.
59 seems to work out of the box.
Thanks!

Comment 4

[Adrian Florinescu [:aflorinescu]]

Sylvestre, for the OAK build for 57 from comment 3, the update gets stuck - I can't update at all.
On Mac OsX(10.13.3):
- about:nightly - shows update available -restart to update
- upon every restart, I get prompted the Mac auth to install a new helper after which it looks like trying to update something.
- when it restarts, the pop-up Software update is displayed again: I either get stuck into the restart to update dialog or the "Nightly can't update".

Should I try updates from older 59 oak to 59 oak?

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Ah, glad you are having this error. I had it once but could not reproduce.
Could you please share what you have in the Browser console ? (Tools => Web Developer => Browser Console)
Thanks

I am not sure why it is working for me... Are you trying that with admin permissions?

Comment 6

[Adrian Florinescu [:aflorinescu]]

To summarize what we've also discussed on slack, I am running on admin account + there is nothing relevant in the browser console.
I've also tried with the 58 oak build (http://ftp.mozilla.org/pub/firefox/nightly/latest-oak/firefox-58.0a1.en-US.mac.dmg) and for 58 oak it just throws the "Nightly can't update".