1427045 - Search glass missing from SeaMonkey search bar after Bug 1380268

Status: RESOLVED FIXED

(SeaMonkey :: Search, defect)

Description

[Frank-Rainer Grahl (:frg)]

If you add a search field to a toolbar the glass icon at the right side is missing but can be clicked. Search-glass.png was removed in Bug 1380268 and replaced with a hard to see plain gray svg.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1427045-searchglass-56.patch 2.53 version

Stefan, I think you mentioned this before but I didn't find an existing bug.

Comment 2

[Stefan [:stefanh]]

Comment on attachment 8938840 [details] [diff] [review]
1427045-searchglass-56.patch 2.53 version

On mac, I like the toolkit svg :-) Anyway, this doesn't affect mac, because the mac version of the file already use a png (which I don't think fit with the toolkit one that can be seen in the findbar... hmm).

Back to the subject: What about the icon in the findbar? Shouldn't that look the same?

Comment 3

[Stefan [:stefanh]]

Btw, the patch doesn't apply on trunk.

Comment 4

[Stefan [:stefanh]]

One more thing: is the icon that you want to add the same as https://dxr.mozilla.org/comm-central/rev/39910427c7e99008fa3d061e972efc89166a5c31/suite/themes/classic/mac/communicator/search/searchbar-search.png?

Comment 5

[Frank-Rainer Grahl (:frg)]

> One more thing: is the icon that you want to add the same as searchbar-search.png?

No. This is a gray icon and is actually looking ok. If it does have three states we could use it also. The search-glass.png was previously used for all search text boxes in toolkit (not on OSX).

> What about the icon in the findbar? Shouldn't that look the same?

Thought about it but it is a simple button image and was always different. Actually I would rather use svgs for everything too for better scaling but not so cheap looking :)

Sorry will rebase the patch. Did it on 2.53. 2.56 is still a basket case.

Comment 6

[Frank-Rainer Grahl (:frg)]

Attachment: 1427045-searchglass.patch

Patch for comm-central

Comment 7

[Stefan [:stefanh]]

Comment on attachment 8938863 [details] [diff] [review]
1427045-searchglass.patch

+  skin/classic/communicator/icons/search-glass.png                      (communicator/icons/search-glass.png)

skin/classic/communicator/search/search-glass.png        (communicator/search/search-glass.png) is more consistent since there is already an icon in there used by communicator/search/searchbar.css). r=me with that fixed.

Comment 8

[Frank-Rainer Grahl (:frg)]

Attachment: 1427045-searchglass-V2.patch

patch with icon moved to search. r+ from stefanh retained.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6b5debab1881
Add back search-glass.png to SeaMonkeys Classic theme after it was removed in Bug 1380268. r=stefanh

Comment 10

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8938870 [details] [diff] [review]
1427045-searchglass-V2.patch

[Approval Request Comment]
Regression caused by (bug #): Bug 1380268
User impact if declined: no incon in mail and browser search bar
Testing completed (on m-c, etc.): c-r 2.53
Risk to taking this patch (and alternatives if risky): none cosmetic
String changes made by this patch: --

Comment 11

[Frank-Rainer Grahl (:frg)]

Attachment: Capture.PNG

Actually search.png also has three states so search-glass.png could replace it 1:1. I think search.png looks very outdated so let me know if I should do a followup bug.

Comment 12

[Ian Neal]

Comment on attachment 8938870 [details] [diff] [review]
1427045-searchglass-V2.patch

a=me

Comment 13

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-beta/rev/03c352b2332a793f9e8876d333ab2ae035588f11

Comment 14

[Ian Neal]

Comment on attachment 8938871 [details]
Capture.PNG

Not sure this is needed any more but f+ anyway

Comment 15

[Ian Neal]

Some more padding might be required as it is a little close to "Search" and the button size has shrunk slightly

Comment 16

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8938871 [details]
Capture.PNG

Note to myself: file a followup bug.

Comment 17

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/1aa3219416054c0e8ff3030c00d3730c67d11c4e