Closed
Bug 1427045
Opened 8 years ago
Closed 8 years ago
Search glass missing from SeaMonkey search bar after Bug 1380268
Categories
(SeaMonkey :: Search, defect)
Tracking
(seamonkey2.53+ fixed, seamonkey2.54 wontfix, seamonkey2.55 fixed, seamonkey2.56 fixed)
RESOLVED
FIXED
seamonkey2.56
People
(Reporter: frg, Assigned: frg, NeedInfo)
Details
Attachments
(2 files, 2 obsolete files)
4.82 KB,
patch
|
frg
:
review+
iannbugzilla
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
22.70 KB,
image/png
|
iannbugzilla
:
feedback+
|
Details |
If you add a search field to a toolbar the glass icon at the right side is missing but can be clicked. Search-glass.png was removed in Bug 1380268 and replaced with a hard to see plain gray svg.
![]() |
Assignee | |
Comment 1•8 years ago
|
||
Stefan, I think you mentioned this before but I didn't find an existing bug.
Attachment #8938840 -
Flags: review?(stefanh)
Comment 2•8 years ago
|
||
Comment on attachment 8938840 [details] [diff] [review]
1427045-searchglass-56.patch 2.53 version
On mac, I like the toolkit svg :-) Anyway, this doesn't affect mac, because the mac version of the file already use a png (which I don't think fit with the toolkit one that can be seen in the findbar... hmm).
Back to the subject: What about the icon in the findbar? Shouldn't that look the same?
Comment 3•8 years ago
|
||
Btw, the patch doesn't apply on trunk.
Comment 4•8 years ago
|
||
One more thing: is the icon that you want to add the same as https://dxr.mozilla.org/comm-central/rev/39910427c7e99008fa3d061e972efc89166a5c31/suite/themes/classic/mac/communicator/search/searchbar-search.png?
![]() |
Assignee | |
Comment 5•8 years ago
|
||
> One more thing: is the icon that you want to add the same as searchbar-search.png?
No. This is a gray icon and is actually looking ok. If it does have three states we could use it also. The search-glass.png was previously used for all search text boxes in toolkit (not on OSX).
> What about the icon in the findbar? Shouldn't that look the same?
Thought about it but it is a simple button image and was always different. Actually I would rather use svgs for everything too for better scaling but not so cheap looking :)
Sorry will rebase the patch. Did it on 2.53. 2.56 is still a basket case.
![]() |
Assignee | |
Updated•8 years ago
|
Attachment #8938840 -
Attachment description: 1427045-searchglass.patch → 1427045-searchglass-56.patch 2.53 version
Attachment #8938840 -
Flags: review?(stefanh)
![]() |
Assignee | |
Comment 6•8 years ago
|
||
Patch for comm-central
Attachment #8938863 -
Flags: review?(stefanh)
Comment 7•8 years ago
|
||
Comment on attachment 8938863 [details] [diff] [review]
1427045-searchglass.patch
+ skin/classic/communicator/icons/search-glass.png (communicator/icons/search-glass.png)
skin/classic/communicator/search/search-glass.png (communicator/search/search-glass.png) is more consistent since there is already an icon in there used by communicator/search/searchbar.css). r=me with that fixed.
Attachment #8938863 -
Flags: review?(stefanh) → review+
![]() |
Assignee | |
Comment 8•8 years ago
|
||
patch with icon moved to search. r+ from stefanh retained.
Attachment #8938840 -
Attachment is obsolete: true
Attachment #8938863 -
Attachment is obsolete: true
Attachment #8938870 -
Flags: review+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/6b5debab1881
Add back search-glass.png to SeaMonkeys Classic theme after it was removed in Bug 1380268. r=stefanh
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
![]() |
Assignee | |
Updated•8 years ago
|
Hardware: All → Unspecified
Target Milestone: --- → Seamonkey2.56
![]() |
Assignee | |
Comment 10•8 years ago
|
||
Comment on attachment 8938870 [details] [diff] [review]
1427045-searchglass-V2.patch
[Approval Request Comment]
Regression caused by (bug #): Bug 1380268
User impact if declined: no incon in mail and browser search bar
Testing completed (on m-c, etc.): c-r 2.53
Risk to taking this patch (and alternatives if risky): none cosmetic
String changes made by this patch: --
Attachment #8938870 -
Flags: approval-comm-beta?
![]() |
Assignee | |
Comment 11•8 years ago
|
||
Actually search.png also has three states so search-glass.png could replace it 1:1. I think search.png looks very outdated so let me know if I should do a followup bug.
Attachment #8938871 -
Flags: feedback?(stefanh)
Attachment #8938871 -
Flags: feedback?(iann_bugzilla)
Comment 12•8 years ago
|
||
Comment on attachment 8938870 [details] [diff] [review]
1427045-searchglass-V2.patch
a=me
Attachment #8938870 -
Flags: approval-comm-beta? → approval-comm-beta+
![]() |
Assignee | |
Comment 13•7 years ago
|
||
Comment 14•7 years ago
|
||
Comment on attachment 8938871 [details]
Capture.PNG
Not sure this is needed any more but f+ anyway
Attachment #8938871 -
Flags: feedback?(iann_bugzilla) → feedback+
Comment 15•7 years ago
|
||
Some more padding might be required as it is a little close to "Search" and the button size has shrunk slightly
![]() |
Assignee | |
Comment 16•7 years ago
|
||
Comment on attachment 8938871 [details]
Capture.PNG
Note to myself: file a followup bug.
Flags: needinfo?(frgrahl)
Attachment #8938871 -
Flags: feedback?(stefanh)
![]() |
Assignee | |
Comment 17•5 years ago
|
||
Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/1aa3219416054c0e8ff3030c00d3730c67d11c4e
tracking-seamonkey2.53:
--- → +
Updated•3 months ago
|
Version: SeaMonkey 2.53 Branch → SeaMonkey 2.53
You need to log in
before you can comment on or make changes to this bug.
Description
•