Closed Bug 1427060 Opened 2 years ago Closed 2 years ago
Item should use ns Atom instead of ns String
59 bytes, text/x-review-board-request
Due to reducing NS_Atomize call and string compare.
Comment on attachment 8938849 [details] Bug 1427060 - PropItem should use nsAtom instead of nsString. https://reviewboard.mozilla.org/r/209340/#review215194 It's unclear if atom argument can take nullptr as valid argument. If we could name nullable atom argument as self-documented, it'd be better. But I have no idea.
Attachment #8938849 - Flags: review?(masayuki) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 3969f288e249 -d 2df842dce673: rebasing 440435:3969f288e249 "Bug 1427060 - PropItem should use nsAtom instead of nsString. r=masayuki" (tip) merging editor/libeditor/HTMLStyleEditor.cpp warning: conflicts while merging editor/libeditor/HTMLStyleEditor.cpp! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ca70091cdc76 PropItem should use nsAtom instead of nsString. r=masayuki
You need to log in before you can comment on or make changes to this bug.