Closed Bug 1427079 Opened 2 years ago Closed 2 years ago

Crash in java.lang.NullPointerException: NativeException NullHandle() [T = nsWindow::GeckoViewSupport] at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)

Categories

(GeckoView :: General, defect, critical)

58 Branch
All
Android
defect
Not set
critical

Tracking

(firefox-esr52 unaffected, firefox57 unaffected, firefox58 wontfix, firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: philipp, Assigned: jchen)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is
report bp-b960de08-e64c-495c-bada-7afaf0171226.
=============================================================

Top 10 frames of crashing thread:

0 libxul.so mozilla::jni::detail::ProxyNativeCall<nsWindow::GeckoViewSupport, mozilla::java::GeckoSession::Window, false, true, const mozilla::jni::Ref<mozilla::jni::Object, _jobject*>&, const mozilla::jni::Ref<mozilla::jni::Object, _jobject*>&>::Call<false, true, 0, 1> widget/android/jni/Natives.h:427
1 libxul.so mozilla::jni::detail::ProxyNativeCall<nsWindow::GeckoViewSupport, mozilla::java::GeckoSession::Window, false, true, const mozilla::jni::Ref<mozilla::jni::Object, _jobject*>&, const mozilla::jni::Ref<mozilla::jni::Object, _jobject*>&>::operator widget/android/jni/Natives.h:499
2 libxul.so nsWindow::WindowEvent<mozilla::jni::detail::ProxyNativeCall<nsWindow::GeckoViewSupport, mozilla::java::GeckoSession::Window, false, true, const mozilla::jni::Ref<mozilla::jni::Object, _jobject*>&, const mozilla::jni::Ref<mozilla::jni::Object, _jobject*>&>, false, const mozilla::jni::Ref<mozilla::java::GeckoSession::Window, _jobject*>&, nsWindow::GeckoViewSupport>::Run widget/android/nsWindow.cpp:161
3 libxul.so nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1039
4 libxul.so NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:510
5 libxul.so nsThreadManager::SpinEventLoopUntil xpcom/threads/nsThreadUtils.h:323
6 libxul.so NS_InvokeByIndex 
7 libxul.so XPCWrappedNative::CallMethod js/xpconnect/src/XPCWrappedNative.cpp:1948
8 libxul.so XPC_WN_CallMethod js/xpconnect/src/XPCWrappedNativeJSOps.cpp:929
9 libxul.so js::InternalCallOrConstruct js/src/jscntxtinlines.h:291

=============================================================

these crashes start to show up in fennec 58 with crash reason "MOZ_CRASH(JNI exception)" and the following java stack trace:

java.lang.NullPointerException: NativeException NullHandle() [T = nsWindow::GeckoViewSupport]
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:407)
jchen, can you take a look?
Flags: needinfo?(nchen)
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Flags: needinfo?(nchen)
Comment on attachment 8941210 [details]
Bug 1427079 - Don't let disposed window be read from parcels;

https://reviewboard.mozilla.org/r/211480/#review217282
Attachment #8941210 - Flags: review?(snorp) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b6d240f90874
Don't let disposed window be read from parcels; r=snorp
https://hg.mozilla.org/mozilla-central/rev/b6d240f90874
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Backout by aciure@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/1ce9b4193d62
Backed out changeset b6d240f90874 for failing testBookmarklets for the robocop-1 job a=backout
Backed out changeset b6d240f90874 (bug 1427079) for failing testBookmarklets for the robocop-1 job a=backout

https://treeherder.mozilla.org/logviewer.html#?job_id=155541388&repo=autoland

https://hg.mozilla.org/mozilla-central/rev/1ce9b4193d624d5d4ed4bceecfbeb1514f818848
Status: RESOLVED → REOPENED
Flags: needinfo?(nchen)
Resolution: FIXED → ---
Target Milestone: Firefox 59 → ---
Trying again with updated patch.
Flags: needinfo?(nchen)
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/adb5fab118c5
Don't let disposed window be read from parcels; r=snorp
https://hg.mozilla.org/mozilla-central/rev/adb5fab118c5
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Still seeing crashes with this signature after this landed, e.g.
https://crash-stats.mozilla.com/report/index/051c3184-aca6-4fa4-96a8-1df750180117
Flags: needinfo?(nchen)
I'll look at it in bug 1431201
Flags: needinfo?(nchen)
Product: Firefox for Android → GeckoView
Version: Firefox 58 → 58 Branch
Keywords: crash, regression
Target Milestone: Firefox 59 → mozilla59
You need to log in before you can comment on or make changes to this bug.