Closed Bug 14271 Opened 20 years ago Closed 20 years ago

[beta] Period key mapped to forward-delete

Categories

(Core :: Editor, defect, P1, blocker)

x86
Windows NT
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: phil, Assigned: buster)

References

Details

When I type the period key, I don't get a period The editor appears to think
that the period key should do a forward-delete
This may be related to my checkin which moved key handling from KeyDown to
KeyPress.  Everyone involved with key events agreed that we should be handling
events in KeyDown, but the Windows key event code may have a bug where it's
setting the key code to VK_DELETE on a KeyPress event of '.'.

Someone with a Windows build (mine from Friday crashed on startup) might want to
set a breakpoint in the KeyPress handler of nsEditorEventListeners.cpp and see
if this is what's happening when you type a '.'.  If so, whoever owns the
Windows key events (Tague?  Rod?  Joki?) needs to fix the Windows KeyPress
handler.

Anyone on Windows who is blocked by this might try (as a temporary fix)
reverting nsEditorKeyListeners.cpp to version 1.97.
Severity: enhancement → blocker
Status: NEW → RESOLVED
Closed: 20 years ago
Priority: P3 → P1
Resolution: --- → FIXED
Summary: Period key mapped to forward-delete → [beta] Period key mapped to forward-delete
fixed blocker.
This is only a partial fix for the larger problem of editor key event handlers,
because the whole key handling process is still in flux.  See discussion on
netscape.public.mozilla.xpfe.
The error in the code was that it was checking for some vk_* keys using the
keycode value before it checked for a charcode value.  charcodes win over
keycodes in keypress handlers.
Status: RESOLVED → REOPENED
I update the mozilla/editor/base/src/nsEditorEventListeners.cpp to rev 1.101.
The '.' key now could be typed in the URL bar. But the "Delete" key below
"Insert" and left to "End" key no longer work in the URL field.

I reopen this because I believe it is realated. Mark it resolve if you don't
think so.
Depends on: 14348
I've filed bug 14348 to Tague on the bug with the Windows key event handler.
Since this is now reopened, I'm making a dependency on that bug for this one.
Status: REOPENED → RESOLVED
Closed: 20 years ago20 years ago
Target Milestone: M11
It's only sort of related, but in any event it's fixed. sujay, this will be in
tomorrow's build.  checking in as soon as the tree opens.
Status: RESOLVED → VERIFIED
verified in 9/21 build.
You need to log in before you can comment on or make changes to this bug.