1427238 - TypeError: items is null[Learn More] SiteDataManager.jsm:53:1

Status: RESOLVED WORKSFORME

(Core :: Storage: Quota Manager, defect, P2)

Description

[Jan [:Jan\]]

about:preferences#privacy

site data stuck "Calculating site data size…"

from error console:
TypeError: items is null[Learn More]  SiteDataManager.jsm:53:1



websites say "Your browser does not support data storage." because of this.

Comment 1

[Jan [:Jan\]]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
57.0.2

Comment 2

[Tooru Fujisawa [:arai]]

here's the code.

https://dxr.mozilla.org/mozilla-release/rev/c548334d172bd937da77e36867473d861cfa2217/browser/components/preferences/SiteDataManager.jsm#53
> this.SiteDataManager = {
> ...
>   _getQuotaUsage() {
> ...
>     this._getQuotaUsagePromise = new Promise(resolve => {
>       let onUsageResult = request => {
>         let items = request.result;
>         for (let item of items) {

it looks like request.result can be null in some case.

Comment 3

[Johann Hofmann [:johannh]]

This seems like a bug in QuotaManagerService::GetUsage to me rather than a bug in preferences.

Comment 4

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Hi Shawn, please take a look.

Comment 5

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Thanks for reporting this bug.
I suspect this is related to storage folder metadata missing.
Do you have any STR to reproduce this error?

If with a new profile, can you still reproduce the bug?
If with the new profile, the bug can't be reproduced, can you share your profile storage folder to me?

Enter "about:support" in URL bar, and check "Profile Directory", there is one "storage" folder, can you share with me in private?

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I now suspected that this is related to lock issue. Some web page is still holding lock therefore site data page can't get the chance to do the request.

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I can now reproduce this symptom.
My STR:
1. Navigate https://shawnjohnjr.github.io/persist-demo/indexedbtest.html
2. Go to preference and check Site Data management.

Comment 8

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

If DirectoryLock was not released, we could see this symptom. When DirectoryLock is released, that API should be able to query the string anyway.

Comment 9

[Jens Stutte [:jstutte]]

:janv, is this still to be considered P2?

Comment 10

[Jan Varga [:janv]]

This has been fixed by adding a check for request.resultCode:
https://searchfox.org/mozilla-central/rev/df94cd5ba431234bc220ac081def0801fe44b89e/browser/modules/SiteDataManager.jsm#140

There was no such check previously:
https://dxr.mozilla.org/mozilla-release/rev/c548334d172bd937da77e36867473d861cfa2217/browser/components/preferences/SiteDataManager.jsm#53