1427239 - Crash in java.lang.NullPointerException: Attempt to invoke virtual method ''void org.mozilla.gecko.FormAssistPopup.destroy()'' on a null object reference at org.mozilla.gecko.webapps.WebAppActivity.onDestroy(WebAppActivity.java)

Status: VERIFIED FIXED

(Toolkit :: General, defect)

Description

[vihsa]

This bug was filed from the Socorro interface and is
report bp-f4579e1b-5d1b-43a8-86c3-09bab0171228.
=============================================================

Top 10 frames of crashing thread:

0 libxul.so GeckoAppShellSupport::ReportJavaCrash widget/android/nsAppShell.cpp:276
1 libxul.so mozilla::jni::NativeStub<mozilla::java::GeckoAppShell::ReportJavaCrash_t, GeckoAppShellSupport, mozilla::jni::Args<const mozilla::jni::Ref<mozilla::jni::TypedObject<_jthrowable*>, _jthrowable*>&, const mozilla::jni::StringParam&> >::Wrap<&GeckoAppShellSupport::ReportJavaCrash> widget/android/jni/Natives.h:778
2 data@[e-mail][e-mail] data@[e-mail][e-mail]@0xeff85d 
3 dalvik-non moving space (deleted) dalvik-non moving space @0x99c6 
4 dalvik-main space (deleted) dalvik-main space @0x167fe 
5 dalvik-main space (deleted) dalvik-main space @0x2af81e 
6 dalvik-main space (deleted) dalvik-main space @0x2e931e 
7 dalvik-main space (deleted) dalvik-main space @0x2e931e 
8 dalvik-non moving space (deleted) dalvik-non moving space @0x9e5e 
9 dalvik-main space (deleted) dalvik-main space @0x2e931e 

=============================================================

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1427239 - Always create FormAssistPopup in WebAppActivity;

Right now we create FormAssistPopup in WebAppActivity based on whether
the manifest is successfully loaded. We should always create it because
we always try to destroy it in onDestroy().

Review commit: https://reviewboard.mozilla.org/r/218794/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218794/

Comment 2

[Dylan Roeh (:droeh) (he/him)]

Comment on attachment 8949480 [details]
Bug 1427239 - Always create FormAssistPopup in WebAppActivity;

https://reviewboard.mozilla.org/r/218794/#review224604

lgtm

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74f5b6977fbe
Always create FormAssistPopup in WebAppActivity; r=droeh

Comment 4

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/74f5b6977fbe

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8949480 [details]
Bug 1427239 - Always create FormAssistPopup in WebAppActivity;

Approval Request Comment
[Feature/Bug causing the regression]: n/a
[User impact if declined]: crash using web apps
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple fix for crash
[String changes made/needed]: none

Comment 6

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8949480 [details]
Bug 1427239 - Always create FormAssistPopup in WebAppActivity;

Fix for a new crash in 59, let's take this for beta 10.

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e1b7cf0d65ab

Comment 8

[Calixte Denizet (:calixte)]

No more crashes in nightly and beta since the patch landed.

Comment 9

[Chris Peterson [:cpeterson]]

Removing tracking-fennec? flag because this bug has been fixed.