No icon shown for message dragged to attachment bucket due to missing type indication

RESOLVED FIXED in Thunderbird 59.0

Status

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jorgk, Assigned: jorgk)

Tracking

Trunk
Thunderbird 59.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
This old bug has become apparent now that space is reserved for items in the attachment bucket.

When dragging a message to the attachment bucket, no icon is shown. This can be fixed manually in the DOM Inspector by appending contentType=message/rfc822 to the icon src.

Note that icons are shown in the attachment area of sent messages or saved drafts.

Attachment bucked icon src:
moz-icon:mailbox-message://.../Inbox#15018
moz-icon:imap-message://.../INBOX#7277

Attachment area icon src for sent/draft messages:
moz-icon://....eml?size=16&contentType=message/rfc822

Maybe fixable in the drop handler in MsgComposeCommands.js envelopeDragObserver.onDrop() for "text/x-moz-message" although I don't see how the icon is set there.
Assignee

Comment 1

2 years ago
Any idea where that icon src is set (I haven't looked at all).
Flags: needinfo?(acelists)
Assignee

Comment 2

2 years ago
Oops, false alarm. Adding contentType=message/rfc822 does nothing. The icon comes when adding .eml somewhere in the src.
Summary: No icon shown for message dragged to attachment bucket due to missing contentType=message/rfc822 → No icon shown for message dragged to attachment bucket due to missing type indication
Assignee

Comment 3

2 years ago
Found it, patch coming.
Flags: needinfo?(acelists)
Assignee

Comment 4

2 years ago
Testing for *-message URLs is ugly, but done elsewhere in the file.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #8939036 - Flags: review?(acelists)

Comment 5

2 years ago
Comment on attachment 8939036 [details] [diff] [review]
1427265-message-icon.patch

Review of attachment 8939036 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, works for me.
I get multiple errors while dragging the message into attachments (on linux), like this:
00:11:04.287 NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsITransferable.getTransferData] 1 msgMail3PaneWindow.js:1375
	getFlavorData chrome://messenger/content/msgMail3PaneWindow.js:1375:5

But that probably isn't related.
Attachment #8939036 - Flags: review?(acelists) → review+
Assignee

Comment 6

2 years ago
Thanks. Hmm, I don't get this error, I only get the error from bug 1427297.

Comment 7

2 years ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/a64eb1d3d916
provide better moz-icon for messages attached via drag&drop. r=aceman
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Assignee

Updated

2 years ago
Target Milestone: --- → Thunderbird 59.0
You need to log in before you can comment on or make changes to this bug.