Closed Bug 1427285 Opened 2 years ago Closed 2 years ago

BuildConfig.MOZ_CRASHREPORTER returns false even with crash reporter enabled

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect, major)

All
Android
defect
Not set
major

Tracking

(fennec+, firefox57 unaffected, firefox58 unaffected, firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
fennec + ---
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 --- fixed

People

(Reporter: JanH, Assigned: JanH)

References

Details

(Keywords: regression)

Attachments

(1 file)

When attempting to reproduce the crash from bug 1426613 (see bug 1426613 comment 8), I've noticed that when I succeed in crashing Firefox the crash is logged to logcat by our GeckoCrashHandler, but the Crash Reporter itself doesn't run. 

Instead, I only get the standard Android message that Firefox has stopped.

Now testing locally I've run a build with "export MOZ_CRASHREPORTER=1" in my mozconfig and thought I'd simply temporarily disable the additional check for an official build in https://dxr.mozilla.org/mozilla-central/rev/f5a1cb52c12e8fbcf2e3b5a675fe2a84d43507a7/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java#167.

However I've noticed that for some reason apparently BuildConfig.MOZ_CRASHREPORTER evaluates to false as well, even though as I said above I've enabled the crash reporter in my mozconfig and this fact is also reflected in the generated build output versions of both AppConstants.jsm and AppConstants.java.

I've then decompiled one of our release Nightly APKs and found the same issue: MOZILLA_OFFICIAL is correctly set to true in BuildConfig.java, but MOZ_CRASHREPORTER isn't.
Flags: needinfo?(nalexander)
It was simply a typo in Geckoview's build.gradle.
Flags: needinfo?(nalexander)
Assignee: nobody → jh+bugzilla
Comment on attachment 8939024 [details]
Bug 1427285 - Fix typo in build.gradle to correctly reflect crash reporter state in BuildConfig.

https://reviewboard.mozilla.org/r/209460/#review215162

Trivial fix, r=me
Attachment #8939024 - Flags: review+
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/8ee11d296e38
Fix typo in build.gradle to correctly reflect crash reporter state in BuildConfig. r=JanH
Yikes.  Thanks, JanH!
https://hg.mozilla.org/mozilla-central/rev/8ee11d296e38
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
tracking-fennec: ? → +
Comment on attachment 8939024 [details]
Bug 1427285 - Fix typo in build.gradle to correctly reflect crash reporter state in BuildConfig.

Approval Request Comment
[Feature/Bug causing the regression]: https://bugzilla.mozilla.org/show_bug.cgi?id=1415778

[User impact if declined]: potential for issues with crash reporter.

[Is this code covered by automated tests?]: yes, to the extent that the crash reporter is tested.

[Has the fix been verified in Nightly?]: unknown.  It's a typo, it's obviously wrong, we shouldn't risk it being wrong on release.


[Needs manual test from QE? If yes, steps to reproduce]: not really.

[List of other uplifts needed for the feature/fix]: none.

[Is the change risky?]: no, I don't think so.

[Why is the change risky/not risky?]: I'm pretty sure the typoed value is not used, but it might as well be correct if it's there.

[String changes made/needed]: none.
Attachment #8939024 - Flags: approval-mozilla-beta?
Comment on attachment 8939024 [details]
Bug 1427285 - Fix typo in build.gradle to correctly reflect crash reporter state in BuildConfig.

A bit of confusion there, but bug 1415778 only landed in 59, so no uplift required.
Attachment #8939024 - Flags: approval-mozilla-beta?
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 59 → mozilla59
You need to log in before you can comment on or make changes to this bug.