Closed
Bug 1427295
Opened 6 years ago
Closed 6 years ago
Remove unused Angular modules
Categories
(Tree Management :: Treeherder: Frontend, enhancement, P2)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
Even though we install the additional packages for / enable these official AngularJS features, it doesn't look like we're actually using any functionality from them: https://docs.angularjs.org/api/ngCookies https://docs.angularjs.org/api/ngSanitize
|
||
Comment 1•6 years ago
|
||
|
Assignee | |
Updated•6 years ago
|
Attachment #8939034 -
Flags: review?(cdawson)
|
|
Assignee | |
Comment 2•6 years ago
|
||
This is deployed to prototype for testing, along with the other PRs.
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8939034 [details] [review] Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3076 Tested on prototype, but I couldn't find any problems with this. :)
Attachment #8939034 -
Flags: review?(cdawson) → review+
|
||
Comment 4•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/a83ee853c7b5687ebf6b6e588c08c9578ad545a2 Bug 1427295 - Remove unused angular-cookies (#3076) Since we don't use any of the functionality provided by it: https://docs.angularjs.org/api/ngCookies#module-components
|
|
Assignee | |
Updated•6 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•