Closed Bug 1427312 Opened 2 years ago Closed 2 years ago

Add mechanism to create tasks to compare firefox builds

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla59

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

I've been comparing firefox builds a *lot* in 3 distinct occasions, and other people have done that too in the past (iirc Callek and maybe pmoore). This time, I've done a lot more comparisons than I have in the past, so I went the extra mile and automated it. I think it would be useful to land the facility.

Plus I'm going to attach non-land-worthy patches relying on it to bugs leading to bug 1399679)
Depends on: 1427266
Blocks: 1399679
Blocks: 1427316
Blocks: 1427339
Comment on attachment 8939044 [details]
Bug 1427312 - Add mechanism to create tasks to compare Firefox builds.

https://reviewboard.mozilla.org/r/209468/#review215462

Nicely done -- especially the final verification.

::: taskcluster/docs/kinds.rst:358
(Diff revision 5)
>  ------------------------------
>  Dummy tasks to consolidate beetmover-checksums dependencies to avoid taskcluster limits on number of dependencies per task.
> +
> +diffoscope
> +----------
> +Tasks used to compare pairs of Firefox builds using https://diffoscope.org/.

From what I can tell, the intent is to do this in a try push?  A bit of extra instruction here might help someone figure that out later..
Attachment #8939044 - Flags: review?(dustin) → review+
(In reply to Dustin J. Mitchell [:dustin] from comment #7)
> Comment on attachment 8939044 [details]
> Bug 1427312 - Add mechanism to create tasks to compare Firefox builds.
> 
> https://reviewboard.mozilla.org/r/209468/#review215462
> 
> Nicely done -- especially the final verification.
> 
> ::: taskcluster/docs/kinds.rst:358
> (Diff revision 5)
> >  ------------------------------
> >  Dummy tasks to consolidate beetmover-checksums dependencies to avoid taskcluster limits on number of dependencies per task.
> > +
> > +diffoscope
> > +----------
> > +Tasks used to compare pairs of Firefox builds using https://diffoscope.org/.
> 
> From what I can tell, the intent is to do this in a try push?  A bit of
> extra instruction here might help someone figure that out later..

Yeah -- more deets needed on how to use this.  Looks like the examplar use in the binutils ticket (https://bugzilla.mozilla.org/show_bug.cgi?id=1427316) predates this work, so it's not good as a model.
(In reply to Nick Alexander :nalexander (less responsive until Jan 3, 2018) from comment #8)
> Yeah -- more deets needed on how to use this.  Looks like the examplar use
> in the binutils ticket
> (https://bugzilla.mozilla.org/show_bug.cgi?id=1427316) predates this work,
> so it's not good as a model.

It doesn't predate this, fwiw. It uses it.
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/a4b21febc58d
Add mechanism to create tasks to compare Firefox builds. r=dustin
https://hg.mozilla.org/mozilla-central/rev/a4b21febc58d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.