1427336 - Share dot-config between docker images

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1427336 - Fix recursive adding of directories through %include in Dockerfiles.

Giving a directory to %include would copy all leaf files under one
single directory in the context image. The only image affected is
valgrind-build, which ended up having a dot-config/pip.conf file instead
of dot-config/pip/pip.conf, meaning valgrind jobs weren't using the
pip config.

Review commit: https://reviewboard.mozilla.org/r/209478/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209478/

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1427336 - Share dot-config between docker-images.

Review commit: https://reviewboard.mozilla.org/r/209480/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209480/

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8939058 [details]
Bug 1427336 - Share dot-config between docker-images.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/209480/diff/1-2/

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8939057 [details]
Bug 1427336 - Fix recursive adding of directories through %include in Dockerfiles.

https://reviewboard.mozilla.org/r/209478/#review215466

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8939058 [details]
Bug 1427336 - Share dot-config between docker-images.

https://reviewboard.mozilla.org/r/209480/#review215468

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a130a39a1ff
Fix recursive adding of directories through %include in Dockerfiles. r=dustin
https://hg.mozilla.org/integration/autoland/rev/20dcc54de92a
Share dot-config between docker-images. r=dustin

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/a0a92beb14a0
Fix recursive adding of directories through %include in Dockerfiles. r=dustin
https://hg.mozilla.org/mozilla-central/rev/434bb0dec5f7
Share dot-config between docker-images. r=dustin

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a0a92beb14a0
https://hg.mozilla.org/mozilla-central/rev/434bb0dec5f7

Comment 9

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/5a130a39a1ff
https://hg.mozilla.org/mozilla-central/rev/20dcc54de92a