1427356 - Fix unhandled promise rejections in azure-blob-storage

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

(node:4693) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 8): Error: Refreshed SAS, but got a Shared-Access-Signature that expires less than options.minSASAuthExpiry from now, signature expiry: 2017-12-29T13:01:12Z
(node:4693) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

This seems to pass with node 6 but fail with 8:

  Data Container - Tests for authentication with SAS from auth.taskcluster.net
Constants file does not exist, setting constants to {}
    ✓ should create an instance of data container (105ms)
    ✓ should create an instance of data container with read-only access and try to create a blob (65ms)
    ✓ should create a data block blob (63ms)
    1) should call for every operation, expiry < now => refreshed SAS

  Azure Blob Storage - Data Container Version Support
    ✓ should create a dataBlockBlob in a container with version 1 of schema (100ms)
    ✓ should create a dataBlockBlob in a data container with version 2 of json schema (136ms)
    ✓ should load a dataBlockBlob with v1 from a data container with v2 (213ms)
    ✓ should create an append data blob with version 1 of schema, update the content with v2 (235ms)


  35 passing (36s)
  1 failing

  1) Data Container - Tests for authentication with SAS from auth.taskcluster.net
       should call for every operation, expiry < now => refreshed SAS:
     Expected no error., assumed `false` to equal (===) true

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/fast-azure-storage/pull/27

..but that just leaves the tests failing.  I suspect these tests never worked, and we just didn't know it.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/azure-blob-storage/pull/3

I don't think this is enough, but it should be a start.  I suspect most of the bugs here are in fast-azure-storage.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

I think this is all fixed now, between the two PRs