Remove "autocomplete-result-popup" and related bindings

RESOLVED FIXED in Firefox 60

Status

()

P2
normal
RESOLVED FIXED
11 months ago
9 months ago

People

(Reporter: Paolo, Assigned: Paolo)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

11 months ago
The tree-based "autocomplete-result-popup" binding can be removed together with related bindings after the last use in the search bar has been removed.
(Assignee)

Updated

11 months ago
Blocks: 1427364
(Assignee)

Updated

11 months ago
Depends on: 1427366
(Assignee)

Comment 1

11 months ago
Looks like there is some more work to do in bug 1427366.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 4

11 months ago
We should file a bug for comm-central where autocomplete-result-popup is still used, at least in:
https://dxr.mozilla.org/comm-central/source/suite/common/communicator.css#20
And in general, to make them aware of the change.

Updated

10 months ago
Priority: -- → P2
(Assignee)

Updated

10 months ago
Blocks: 1429115
(Assignee)

Updated

10 months ago
Attachment #8939096 - Flags: review?(mak77)
Attachment #8939097 - Flags: review?(mak77)

Comment 5

10 months ago
mozreview-review
Comment on attachment 8939096 [details]
Bug 1427363 - Part 1 - Remove "autocomplete-result-popup" and related bindings.

https://reviewboard.mozilla.org/r/209518/#review221680
Attachment #8939096 - Flags: review?(mak77) → review+

Comment 6

10 months ago
mozreview-review
Comment on attachment 8939097 [details]
Bug 1427363 - Part 2 - Flatten inheritance for "autocomplete-rich-result-popup".

https://reviewboard.mozilla.org/r/209516/#review221690
Attachment #8939097 - Flags: review?(mak77) → review+

Updated

10 months ago
Blocks: 1432950

Comment 7

9 months ago
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/184034807d27
Part 1 - Remove "autocomplete-result-popup" and related bindings. r=mak
https://hg.mozilla.org/integration/mozilla-inbound/rev/86fa284eb0e0
Part 2 - Flatten inheritance for "autocomplete-rich-result-popup". r=mak

Comment 8

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/184034807d27
https://hg.mozilla.org/mozilla-central/rev/86fa284eb0e0
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60

Comment 9

9 months ago
Thanks Marco, I've seen in, but this is in SM, suite/.
Flags: needinfo?(frgrahl)
Jorg, thanks. Paolo already gave us a heads up in bug 1429115. With luck we don't need to do anything/much. Will test it now that the patches have been pushed.
Flags: needinfo?(frgrahl)
You need to log in before you can comment on or make changes to this bug.