1427363 - Remove "autocomplete-result-popup" and related bindings

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, task, P2)

Description

[:Paolo Amadini]

The tree-based "autocomplete-result-popup" binding can be removed together with related bindings after the last use in the search bar has been removed.

Comment 1

[:Paolo Amadini]

Looks like there is some more work to do in bug 1427366.

Comment 2

[:Paolo Amadini]

Attachment: Bug 1427363 - Part 1 - Remove "autocomplete-result-popup" and related bindings.

Review commit: https://reviewboard.mozilla.org/r/209518/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209518/

Comment 3

[:Paolo Amadini]

Attachment: Bug 1427363 - Part 2 - Flatten inheritance for "autocomplete-rich-result-popup".

Review commit: https://reviewboard.mozilla.org/r/209516/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209516/

Comment 4

[Marco Bonardo [:mak]]

We should file a bug for comm-central where autocomplete-result-popup is still used, at least in:
https://dxr.mozilla.org/comm-central/source/suite/common/communicator.css#20
And in general, to make them aware of the change.

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 8939096 [details]
Bug 1427363 - Part 1 - Remove "autocomplete-result-popup" and related bindings.

https://reviewboard.mozilla.org/r/209518/#review221680

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 8939097 [details]
Bug 1427363 - Part 2 - Flatten inheritance for "autocomplete-rich-result-popup".

https://reviewboard.mozilla.org/r/209516/#review221690

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/184034807d27
Part 1 - Remove "autocomplete-result-popup" and related bindings. r=mak
https://hg.mozilla.org/integration/mozilla-inbound/rev/86fa284eb0e0
Part 2 - Flatten inheritance for "autocomplete-rich-result-popup". r=mak

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/184034807d27
https://hg.mozilla.org/mozilla-central/rev/86fa284eb0e0

Comment 9

[Jorg K (CEST = GMT+2)]

Thanks Marco, I've seen in, but this is in SM, suite/.

Comment 10

[Frank-Rainer Grahl (:frg)]

Jorg, thanks. Paolo already gave us a heads up in bug 1429115. With luck we don't need to do anything/much. Will test it now that the patches have been pushed.