1427433 - default shortcut Crtl-Enter leads to mistakes

Status: RESOLVED DUPLICATE of bug 548604

(Thunderbird :: Message Compose Window, enhancement)

Description

[Jérôme Bouat]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171227151959

Steps to reproduce:

I edited a spreadsheet with LibreOffice Calc for half an hour and decided to send it by email. In the spreadsheet cells, I inserted line breaks by hitting the CRTL-Enter keys.


Actual results:

When I wrote my email, I used CTRL-Enter in order to make a new line but it send the email.


Expected results:

Make this shortcut inactive by defaut. This would help the newbies and the hurried persons.

Comment 1

[Richard Marti (:Paenglab)]

This shortcut is since long time in TB and removing it would upset our users which always use this shortcut.

I'm for WONTFIX as there are always shortcuts that collide with other programs shortcuts.

Comment 2

[Thomas D. (:thomas8)]

(In reply to Jérôme Bouat from comment #0)

Hi Jerome, thanks for posting to help improving TB! :)

> Steps to reproduce:
> 
> I edited a spreadsheet with LibreOffice Calc for half an hour and decided to
> send it by email. In the spreadsheet cells, I inserted line breaks by
> hitting the CRTL-Enter keys.

Your STR's are incomplete, which matters because TB ain't a spreadsheet program...

> Actual results:
> 
> When I wrote my email, I used CTRL-Enter in order to make a new line but it
> send the email.

Well, you pressed Ctrl+Enter at least *twice*, or Ctrl+Enter once and then Enter.
That's unfortunate, because there was a warning message which you knocked out ;)

> Expected results:
> 
> Make this shortcut inactive by defaut. This would help the newbies and the
> hurried persons.

I agree with Richard that this upset much more users than it would help.
I think trying Ctrl+Enter because you know it from your spreadsheet isn't a frequent scenario for writing emails. Excel spreadsheets acutally have Alt+Enter, so it's probably *only* Libre Office. Pressing Shift+Enter as for line breaks in your word processor makes sense, and actually gets you a linebreak in TB.
Although, maybe if you try this in a table in your TB composition, yeah...

Maybe you want to file an RFE for Libre-Office to change this to Alt+Enter as in Excel? That would eliminate the problem in the long run. (btw, apparently Shift+Enter works to confirm the cell and shift cell focus *upwards*).

I guess we can move this discussion over to Bug 548604, of which this is a duplicate.

Here's my ideas what we should and shouldn't do:

1) Fix Bug 620853 / Bug 620849. Only plain Enter must confirm the dialogue, and holding Ctrl+Enter for a little too long must never cause multiple emails to be sent. Keyboard buffer from body must never arrive on the dialogue, even when the dialogue takes long to pop up. Only Enter pressed while dialogue is open must confirm. That would mitigate the risk already and probably eliminate reporter's case.

2) Defaulting to Cancel (patch of Bug 548604) would be the safest, but sounds like a bad idea to me, for those who actually want to use the shortcut with just a split second of double-checking; they certainly appreciate the charming simplicity of Ctrl+Enter, Enter. Here's the quote from that bug:
> One needs to be able to disable this feature OR the default selected button needs to be changed.
There's always this question if warning messages should default to confirming the risky action or not. Permanently deleting files in windows explorer with Shift+DEL defaults to Yes, because it's too frequent to be complicated. Same here.

3) Speaking of seconds: I'm not sure if forcing a short delay before pressing ENTER would be acceptable. A second before enabling send button would stop a lot of accidents, but force fast keyboard users into a minimal delay. Which however is the purpose of this warning dialogue... I wonder which one is worse: minimal delay for the second Enter or having to press another navigation or confirmation key.

3) Change the current checkbox label "Never show me this dialog box again" which is VERY ambiguous:
does it mean to switch this feature OFF or does it mean (as it does currently) "Use this shortcut without confirmation prompt in the future"?

4) An option in options to turn this OFF, completely, as suggested by Bug 548604. Maye even to turn it off from the dialogue. The best way of doing that might be something like 5)

5) I have a feeling that looking at 2), 3), and 4), we really want to make this more configurable, and make such configuration available from the dialogue, especially as long as the configuration hasn't been confirmed.
I imagine something like a "Configure Ctrl+Enter shortcut behaviour..." link on the message. Or a small (i) icon and/or a (gear) icon. From there, going straight into options or a small dialogue of its own, to configure like this:
[x] Use Ctrl+Enter keyboard shortcut to send the message
    [x] Show confirmation prompt before sending the message
        [x] Default to [Send] in the confirmation message
        [x] Delay [Send] button enabling by [ 1.0 ] seconds
        [x] Show configuration link on confirmation message

If we want to be totally professional, we should have something like a first-time safe configuration offer "This is the first time that you have used Ctrl+Enter keyboard shortcut. Please take a minute to configure the behaviour for the future..." [Send message] *[Configure Ctrl+Enter behaviour]*