1427477 - Google tests fail compiling with MS Visual studio 2017 Version 15.5

Status: RESOLVED DUPLICATE of bug 1423649

(Core :: Audio/Video: Playback, defect)

Description

[jbonnafo]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171226083017

Steps to reproduce:

I tried to compile firefox code base using latest version of Microsoft Visual Studio 2017 (version 15.5).



Actual results:

Using this version all projects linked to google tests framework fail compiling with warning messages:

googletest\googletest\include\gtest/gtest-printers.h(617): warning C4996: 'std::tr1': warning STL4002: The non-Standard std::tr1 namespace and TR1-only machinery are deprecated and will be REMOVED. You can define _SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING to acknowledge that you have received this warning.

Code was compiling OK with previous version (15.4) of Microsoft VS 2017 compiler.

The issue seems linked to Google test framework: 
https://github.com/google/googletest/issues/1036


Expected results:

Code should have compiled OK.
I have tried to upgrade locally the code for gtest / gmock to the latest version and it seems to solve the issue.

Comment 1

[jbonnafo]

Hello,

With latest version of gtest, compilation goes OK but i still have some linking errors.
A quick fix would be to define GTEST_HAS_STD_TUPLE at compilation stage, but i don't know how to add this and if this is a possible / good solution.

Thanks,

Comment 2

[Ryan VanderMeulen [:RyanVM]]

This is a dupe of bug 1423649. Assuming you're trying to build something that isn't mozilla-central, you can probably apply the patch from that bug to your local clone to work around it.