1427481 - Replace usage of KeyboardEvent.keyCode by KeyboardEvent.key in calendar

Status: RESOLVED FIXED

(Calendar :: General, enhancement)

Description

[[:MakeMyDay]]

Follow-up to bug 1409560 - since KeyboardEvent.keyCode is deprecated, we should replace occurences in calendar code [1] with KeyboardEvent.key. The other deprecated properties and methods from KeyboardEvent are not present in calendar code.

See [2] for how to key is working.

[1] https://dxr.mozilla.org/comm-central/search?q=path%3Acalendar+.keyCode&redirect=false
[2] https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key

Comment 1

[:aceman]

There should only remain a few instances after bug 1437269, I can look at them.

Comment 2

[:aceman]

Attachment: 1438891.patch

Comment 3

[:aceman]

Attachment: 1427481.patch

Right patch ;)

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8951989 [details] [diff] [review]
1427481.patch

Review of attachment 8951989 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for working on this patch, r=philipp. Two minor nits:

::: calendar/base/content/dialogs/calendar-alarm-dialog.xul
@@ +22,5 @@
>          persist="screenX screenY width height"
>          onload="setupWindow(); window.arguments[0].wrappedJSObject.window_onLoad();"
>          onunload="finishWindow();"
>          onfocus="onFocusWindow();"
> +        onkeypress="if (event.key == 'Escape') { window.close(); }"

double quotes please

::: calendar/lightning/content/messenger-overlay-sidebar.xul
@@ +302,5 @@
>                      oncommand="openInvitationsDialog()">
>        <label id="calendar-invitations-label"
>               class="text-link"
>               onclick="openInvitationsDialog()"
> +             onkeypress="if (event.key == 'Enter') { openInvitationsDialog(); }"/>

double quotes please

Comment 5

[:aceman]

Those two are inside attribute value so we have to use single quotes there. Unless there is another way to do it.

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Ignore previous double quote comments, obviously not sensible in an attribute.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cf8afa5f2ce8
convert remaining event.keyCode uses in calendar. r=philipp