The "Show raw stack data" in Browser hangs in about:telemetry does not work

RESOLVED FIXED in Firefox 59

Status

()

defect
P2
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: o0ignition0o, Assigned: o0ignition0o)

Tracking

Trunk
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(2 attachments)

Posted image chrome-hangs.png
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20170926100259

Steps to reproduce:

In the about:telemetry page, go to the Browser Hangs section.
Click on the "Fetch function names for stacks" link, and click on the "Show raw stack data" button. 


Actual results:

As I clicked on the "Show raw stack data" button, the link did not change, and the Browser Hangs section (on the left side) vanished.

My console reported : ` JavaScript error: , line 0: uncaught exception: TypeError: element.argument is undefined ` 


Expected results:

The link should display "Fetch function names for stacks" again, and the section should still be displayed on the navigation menu.
Comment hidden (mozreview-request)

Updated

a year ago
Component: Untriaged → Telemetry
Product: Firefox → Toolkit
Priority: -- → P2

Comment 2

a year ago
mozreview-review
Comment on attachment 8939253 [details]
Bug 1427484 - Fix about:telemetry "Show raw stack data" button in Browser Hangs section.

https://reviewboard.mozilla.org/r/209682/#review215432

Solid patch, but I think we'll run into a problem with non-current ping data from non-main pings.

::: toolkit/content/aboutTelemetry.js:2055
(Diff revision 1)
>      function() {
>        if (!gPingData) {
>          return;
>        }
>  
> -      ChromeHangs.render(gPingData);
> +      ChromeHangs.render(gPingData.payload.chromeHangs);

chromeHangs may not be present in each gPingData. For instance, a `health` ping does not contain chromeHangs.

Does this patch work when you select a non-main (and non-saved-session) archived ping from the ping selector at the top-left?
Attachment #8939253 - Flags: review?(chutten) → review-
Assignee: nobody → jeremy.lempereur
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 3

a year ago
Hi Chris, and thanks for your response :)
I'll try to reproduce this setup and handle it tonight :)
(Assignee)

Comment 4

a year ago
mozreview-review-reply
Comment on attachment 8939253 [details]
Bug 1427484 - Fix about:telemetry "Show raw stack data" button in Browser Hangs section.

https://reviewboard.mozilla.org/r/209682/#review215432

> chromeHangs may not be present in each gPingData. For instance, a `health` ping does not contain chromeHangs.
> 
> Does this patch work when you select a non-main (and non-saved-session) archived ping from the ping selector at the top-left?

After a bit more investigations, I think a TypeError would be raised if and only if gPingData.payload was undefined. 
If a ping has no chromeHangs (but a payload) The render function should catch it and return early. 

I'm not confident enough with the codebase to claim that each ping has a payload (although it seems legitimate).

I could add an other check on the payload before calling the render function, but we should probably do the same in the LateWrites section too I guess? 

I'm going to enable archiving as displayed in https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/concepts/archiving.html and check how the page behaves :)
(Assignee)

Comment 5

a year ago
mozreview-review-reply
Comment on attachment 8939253 [details]
Bug 1427484 - Fix about:telemetry "Show raw stack data" button in Browser Hangs section.

https://reviewboard.mozilla.org/r/209682/#review215432

> After a bit more investigations, I think a TypeError would be raised if and only if gPingData.payload was undefined. 
> If a ping has no chromeHangs (but a payload) The render function should catch it and return early. 
> 
> I'm not confident enough with the codebase to claim that each ping has a payload (although it seems legitimate).
> 
> I could add an other check on the payload before calling the render function, but we should probably do the same in the LateWrites section too I guess? 
> 
> I'm going to enable archiving as displayed in https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/concepts/archiving.html and check how the page behaves :)

I just tried to watch what happens with non-main and non-saved-session pings and there is just no Chrome Hangs menu being displayed, and I can't find any error in the console :/

Comment 6

a year ago
mozreview-review
Comment on attachment 8939253 [details]
Bug 1427484 - Fix about:telemetry "Show raw stack data" button in Browser Hangs section.

https://reviewboard.mozilla.org/r/209682/#review215554

Good enough for me :)
Attachment #8939253 - Flags: review- → review+

Comment 7

a year ago
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/71b4e1ee7d99
Fix about:telemetry "Show raw stack data" button in Browser Hangs section. r=chutten
(Assignee)

Comment 8

a year ago
Great thank's a lot ! Could you please vouch for me? I want to be a Mozillian too :) I'm https://mozillians.org/en-US/u/ignition/

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/71b4e1ee7d99
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
The Mozillians form asks me if you've made "significant contributions". Cleaning up about:telemetry is a good start, but we should get you a couple of heavier pieces of work before we start the vouching parade :)

What do you think about bug 1249596 ?
Sure, I'm taking it ! :D
You need to log in before you can comment on or make changes to this bug.