Closed Bug 1427509 Opened 2 years ago Closed 2 years ago

Use Photon style icons in Thunderbird

Categories

(Thunderbird :: Theme, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 59.0

People

(Reporter: ntim, Assigned: ntim)

References

(Blocks 1 open bug)

Details

Attachments

(10 files, 10 obsolete files)

671 bytes, image/png
jorgk-bmo
: feedback+
ntim
: feedback+
Details
464 bytes, image/png
jorgk-bmo
: feedback+
Details
529 bytes, image/svg+xml
Paenglab
: feedback+
jorgk-bmo
: feedback+
Details
547 bytes, image/svg+xml
jorgk-bmo
: feedback+
Paenglab
: feedback+
Details
522 bytes, image/svg+xml
Paenglab
: feedback+
Details
552 bytes, image/svg+xml
Paenglab
: feedback+
Details
104.32 KB, patch
Fallen
: review+
Details | Diff | Splinter Review
40.40 KB, image/png
Details
12.92 KB, image/png
Details
1.70 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review
No description provided.
Attached patch photon-icons.patch (obsolete) — Splinter Review
This has all mail/chat/calendar/addressbook icons changed.
Assignee: nobody → ntim.bugs
Attachment #8939272 - Flags: review?(richard.marti)
I won't have time to commit more effort into this, feel free to use the patch as you want :)
Attached patch photon-icons.patch (obsolete) — Splinter Review
Fixed one wrong icon.
Attachment #8939272 - Attachment is obsolete: true
Attachment #8939272 - Flags: review?(richard.marti)
Attachment #8939273 - Flags: review?(richard.marti)
Attachment #8939273 - Attachment is patch: true
Attached patch photon-icons.patch (obsolete) — Splinter Review
Attachment #8939273 - Attachment is obsolete: true
Attachment #8939273 - Flags: review?(richard.marti)
Attachment #8939274 - Flags: review?(richard.marti)
Attached patch photon-icons.patch (obsolete) — Splinter Review
Ok, all icons should have context-fill now.
Attachment #8939274 - Attachment is obsolete: true
Attachment #8939274 - Flags: review?(richard.marti)
Attachment #8939275 - Flags: review?(richard.marti)
Attached patch photon-icons.patch (obsolete) — Splinter Review
Updated the Junk icon.
Attachment #8939275 - Attachment is obsolete: true
Attachment #8939275 - Flags: review?(richard.marti)
Attachment #8939280 - Flags: review?(richard.marti)
Attachment #8939280 - Attachment is patch: true
People love unsolicited comments, so here goes ;-)
Looks nice with these exceptions:
1. Write is a diagonal line with to dots, is this meant to be a pen?
2. Compact was better before, we had a broom (or a rocket??) A broom signifies a clean-sweep, no?
3. Print still needs to be replaced.
4. Add Star(?) doesn't have an icon.
5. Reply All: Not so good, the second arrow is barely visible.
Attached image reply.png
(In reply to Jorg K (GMT+1) from comment #7)
> People love unsolicited comments, so here goes ;-)
> Looks nice with these exceptions:

I like it too.

> 1. Write is a diagonal line with to dots, is this meant to be a pen?

Maybe something like the Monterail pen with a clamp could look better.

> 2. Compact was better before, we had a broom (or a rocket??) A broom
> signifies a clean-sweep, no?

Yes, this needs a new icon.

> 3. Print still needs to be replaced.

No, I used already the Photon Print icon.

> 4. Add Star(?) doesn't have an icon.

This comes from Comactheader extension.

> 5. Reply All: Not so good, the second arrow is barely visible.

Yes, the second arrow is too faint. I made it bolder, see attached screenshot. What do you think about it?
Attachment #8939326 - Flags: feedback?(ntim.bugs)
Attachment #8939326 - Flags: feedback?(jorgk)
Comment on attachment 8939326 [details]
reply.png

Better, thanks. BTW, I don't think I like the new Calendar icon all that much. I can't identify this as a calendar. The task icon is OK.
Attachment #8939326 - Flags: feedback?(jorgk) → feedback+
Comment on attachment 8939326 [details]
reply.png

LGTM!
Attachment #8939326 - Flags: feedback?(ntim.bugs) → feedback+
(In reply to Richard Marti (:Paenglab) from comment #8)
> > 1. Write is a diagonal line with to dots, is this meant to be a pen?
> 
> Maybe something like the Monterail pen with a clamp could look better.

The icon I made is a pencil. I think it's suited for the compose action. A pen would be fine too, it's just harder to make it fit the photon style (and have it snapped to the pixel grid!).

> > 2. Compact was better before, we had a broom (or a rocket??) A broom
> > signifies a clean-sweep, no?
> 
> Yes, this needs a new icon.

I agree the new icon is not super explicit, but I think the broom icon is even less so. Cleaning is removing un-used items. Compacting/compressing is reducing the size of individual items, this is what the 4 arrows pointing in represent.
(In reply to Tim Nguyen :ntim from comment #11)
> I agree the new icon is not super explicit, but I think the broom icon is
> even less so. Cleaning is removing un-used items. Compacting/compressing is
> reducing the size of individual items, this is what the 4 arrows pointing in
> represent.
No. Compacting is about removing (cleaning) superseded/deleted messages. No compaction of individual messages and no compression. So something that signifies cleaning would be good.
(In reply to Tim Nguyen :ntim from comment #11)
> The icon I made is a pencil.
Sorry, it can't be recognised as a "writing tool", it's just a diagonal line with two dots.
Attached image write.png
(In reply to Tim Nguyen :ntim from comment #11)
> Cleaning is removing un-used items.

Removing deleted messages is exactly what is done.

What do you think about my write icon? It looks now more like a pen. I need only to make the gaps sharper.
Attachment #8939334 - Flags: feedback?(ntim.bugs)
Attachment #8939334 - Flags: feedback?(jorgk)
Comment on attachment 8939334 [details]
write.png

That looks like a pen :-)
Attachment #8939334 - Flags: feedback?(jorgk) → feedback+
(In reply to Jorg K (GMT+1) from comment #12)
> (In reply to Tim Nguyen :ntim from comment #11)
> > I agree the new icon is not super explicit, but I think the broom icon is
> > even less so. Cleaning is removing un-used items. Compacting/compressing is
> > reducing the size of individual items, this is what the 4 arrows pointing in
> > represent.
> No. Compacting is about removing (cleaning) superseded/deleted messages. No
> compaction of individual messages and no compression. So something that
> signifies cleaning would be good.

In this case, the label could be changed to "Clean messages". A broom would probably work well. I don't know if I have time to work on it however.

(In reply to Jorg K (GMT+1) from comment #13)
> (In reply to Tim Nguyen :ntim from comment #11)
> > The icon I made is a pencil.
> Sorry, it can't be recognised as a "writing tool", it's just a diagonal line
> with two dots.

https://material.io/icons/#ic_create
(In reply to Tim Nguyen :ntim from comment #16)
> https://material.io/icons/#ic_create
That pen looks good, too, perhaps even better than Richard's since it's simpler. And funnily next to it, there is a "delete sweep".
Attached image compose-v2.svg
What do you think of this version ? It should look more like an actual pencil, or at least the icon in the link: https://material.io/icons/#ic_create

As for Richard's icon, I can see the attempt of making a fountain pen, but if that is the case, then the pen end should also reflect that: https://thenounproject.com/term/pen/1480353/

Right now, the top looks perfectly like an fountain pen, but the pen end looks like a classic pen end, or even a pencil's end.
Attachment #8939341 - Flags: feedback?(richard.marti)
Attachment #8939341 - Flags: feedback?(jorgk)
Comment on attachment 8939341 [details]
compose-v2.svg

Yep. Better than the fountain pen. Now all I need is a broom ;-)
Attachment #8939341 - Flags: feedback?(jorgk) → feedback+
Attached image compact-v2.svg
Attachment #8939342 - Flags: feedback?
Attachment #8939342 - Flags: feedback?(richard.marti)
Attachment #8939342 - Flags: feedback?(jorgk)
Attachment #8939342 - Flags: feedback?
Comment on attachment 8939334 [details]
write.png

see comment 18
Attachment #8939334 - Flags: feedback?(ntim.bugs)
Comment on attachment 8939342 [details]
compact-v2.svg

Nice, better than the broom-rocket we currently have, thanks!
Attachment #8939342 - Flags: feedback?(jorgk) → feedback+
Comment on attachment 8939341 [details]
compose-v2.svg

I like it. Nit: before the pencil's end there it is a bit smaller and the end's angle is less than 90°. This makes it a bit blurry. What do you think about to make it 90°?
Attachment #8939341 - Flags: feedback?(richard.marti) → feedback+
Comment on attachment 8939342 [details]
compact-v2.svg

Bought. :)
Attachment #8939342 - Flags: feedback?(richard.marti) → feedback+
Attached image compose-v3.svg
The end is slightly smaller, but it's snapped to the pixel grid which makes it less blurry.
Attachment #8939366 - Flags: feedback?(richard.marti)
Comment on attachment 8939366 [details]
compose-v3.svg

Perfect, thank you very much!

I'll attach the patch with all changes soon.
Attachment #8939366 - Flags: feedback?(richard.marti) → feedback+
Attached patch photon-icons.patch v2 (obsolete) — Splinter Review
Updated to the latest icons. Fixed the allowed-dupes.mn and removed unneeded </path> etc.

I added a fill of the chat bubble with 50% opacity when new chat messages came in. Normally we see only the bubble border. The pro is also one less dupe in allowed-dupes. :)

In Lightning I removed the duplicate arrows for the today pane and the calendar navigation.
Attachment #8939280 - Attachment is obsolete: true
Attachment #8939280 - Flags: review?(richard.marti)
Attachment #8939378 - Flags: review?(richard.marti)
Attachment #8939378 - Flags: review?(philipp)
Attachment #8939378 - Flags: review?(richard.marti) → review+
Attached image Calendar-screenshot.png (obsolete) —
Screenshot of all Lightning icons for easier review.
Attached image compact-v4.svg
After testing the patch I wasn't too satisfied with the new compact icon, as it didn't match the photon style. Here's a newer version of the icon.
Attachment #8939389 - Flags: feedback?(richard.marti)
Comment on attachment 8939389 [details]
compact-v4.svg

Looks better than the one in patch v2.
Attachment #8939389 - Flags: feedback?(richard.marti) → feedback+
Attached patch photon-icons.patch v2.1 (obsolete) — Splinter Review
Updated the compact icon.

Philipp, for easier review see attachment 8939379 [details].
Attachment #8939378 - Attachment is obsolete: true
Attachment #8939378 - Flags: review?(philipp)
Attachment #8939391 - Flags: review?(philipp)
Attached patch photon-icons.patch v2.2 (obsolete) — Splinter Review
Same patch as v 2.1 with updated priority, status, freebusy and timezones icons.

I think the only icon which need a change is the today icon. But we can do this also later. I'll attach a new screenshot with the updated icons.
Attachment #8939391 - Attachment is obsolete: true
Attachment #8939391 - Flags: review?(philipp)
Attachment #8939414 - Flags: review?(philipp)
Attached image Calendar-screenshot.png (obsolete) —
Updated screenshot for review.
Attachment #8939379 - Attachment is obsolete: true
This should be now the final patch. The calendar icon on top right is changed and the Today icon makes now more sense with this change.
Attachment #8939414 - Attachment is obsolete: true
Attachment #8939414 - Flags: review?(philipp)
Attachment #8939486 - Flags: review?(philipp)
Screenshot for easier review of v2.3.
Attachment #8939415 - Attachment is obsolete: true
Attachment #8939486 - Flags: review?(philipp) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/454eb3e4fa5e
Use Photon style icons in Thunderbird. r=Paenglab,philipp
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 59.0
Looking at this in a Tinderbox build I noticed a few things:
- The thin paper clip (attachment) icon doesn't go well with the thicker new icons
- The coloured tab icons (inbox, drafts, templates, sent, archives, junk, trash,
  account icon and even the folder icons) don't go so well with the new scheme.
  The same goes for the calendar tab and event icons.
  If you use "Customise", you'll also see some Calendar synchronisation icons which are still
  big and colourful like in the XP days.
- You've changed the mail tab icon when opening a message. It used to be an envelop
  (from bug 1404695), and it already had Photon style (Bug 1404695 comment #1).
  Now it's a chat bubble. That's rather unfortunate since a message is not a chat item.
(In reply to Jorg K (GMT+1) from comment #37)
> Created attachment 8939779 [details]
> Screenshot showing inconsistencies
> 
> Looking at this in a Tinderbox build I noticed a few things:
> - The thin paper clip (attachment) icon doesn't go well with the thicker new
> icons
> - The coloured tab icons (inbox, drafts, templates, sent, archives, junk,
> trash,
>   account icon and even the folder icons) don't go so well with the new
> scheme.

This was already before this bug. If we could get SVG files, that would be great.

>   The same goes for the calendar tab and event icons.

Tim and I talked already about this on IRC

>   If you use "Customise", you'll also see some Calendar synchronisation
> icons which are still
>   big and colourful like in the XP days.

You'll be tricked by an extension.

> - You've changed the mail tab icon when opening a message. It used to be an
> envelop
>   (from bug 1404695), and it already had Photon style (Bug 1404695 comment
> #1).
>   Now it's a chat bubble. That's rather unfortunate since a message is not a
> chat item.

A follow-up follows.
Restore the message icon.
Attachment #8939833 - Flags: review?(jorgk)
Comment on attachment 8939833 [details] [diff] [review]
Bug1427509-fup.patch

Looks like you're restoring the message.svg to its previous state, cool for me. I hope Tim agrees.

Since I cancelled today's Daily, I'll land this tonight and no one will have seen it :-)

As for the the synchronise icons: They will come from MyPhoneExplorer.

And the paper clip: Well, it's too thin now, but we can follow up here or in another bug.
Attachment #8939833 - Flags: review?(jorgk) → review+
Status: RESOLVED → REOPENED
Keywords: checkin-needed
Resolution: FIXED → ---
I actually don't remember changing message.svg to the chat icon (and I actually disagree with that change).

I agree to restoring message.svg to the mail icon :)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/ff91862ffb2a
Follow-up: restore the previous message icon which was accidentally replaced. r=jorgk
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Blocks: 1428831
You need to log in before you can comment on or make changes to this bug.