1427510 - Permafailing browser/extensions/formautofill/test/browser/browser_editCreditCardDialog.js | check cc-exp-year - Got 2018, expected 2017

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: dluca [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=153662670&repo=mozilla-central

https://queue.taskcluster.net/v1/task/e4iRKtY3TnWK60A2PkkseQ/runs/0/artifacts/public/test_info/browser-chrome-chunked_errorsummary.log

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/aa6fd6d2a7ce
Use current year as expiration year in credit card test to fix perma failure. r=permafail-fix a=permafail-fix

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/27037bf80310
Use current year as expiration year in credit card test to fix perma failure: fix eslint issue. r=eslint-fix a=eslint-fix

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/a0df091c3697
Disable perma failing browser_editCreditCardDialog.js until it gets fixed. r=permafail-fix a=permafail-fix

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Hi Luke, I disabled browser_editCreditCardDialog.js because it permafailed. The test tries to enter the expired credit card at https://hg.mozilla.org/mozilla-central/annotate/36c1b89781b4/browser/extensions/formautofill/test/browser/head.js#l43 which succeeded until the end of 2017.

A still valid credit card caused failures in browser_creditCard_doorhanger.js:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=27037bf8031067aaea19e6879364bbf7215f1606&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=retry

Comment 6

[Jonathan Kingston [:jkt] he/him]

Looks like if you fix test_saveCreditCard to:
let win = window.openDialog(EDIT_CREDIT_CARD_DIALOG_URL, null, null, TEST_CREDIT_CARD_1);

You get the following:
GECKO(13889) | JavaScript error: file:///.../dist/bin/components/crypto-SDR.js, line 136: NS_ERROR_FAILURE: Couldn't decrypt string
Console message: [JavaScript Error: "NS_ERROR_FAILURE: Couldn't decrypt string" {file: "file:///.../dist/bin/components/crypto-SDR.js" line: 136}]

This makes the test timeout.

Comment 7

[Luke Chang [:lchang] (inactive)]

Thanks for filing this bug and helping identifying the cause. Scott will follow up this issue.

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9bd96538fb1f

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/bfd9bdaf70d72e381285311f48ff9381f67fbb13

Comment 10

[Intermittent Failures Robot]

8 failures in 462 pushes (0.017 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 4
* try: 3
* mozilla-central: 1

Platform breakdown:
* osx-10-10: 4
* windows7-32: 3
* windows10-64-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1427510&startday=2018-01-01&endday=2018-01-07&tree=all

Comment 11

[Scott Wu [:scottwu]]

Attachment: Bug 1427510 - Use current year as expiration year in credit card test case to fix perma failure.

Review commit: https://reviewboard.mozilla.org/r/211310/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211310/

Comment 12

[Scott Wu [:scottwu]]

Comment on attachment 8941016 [details]
Bug 1427510 - Use current year as expiration year in credit card test case to fix perma failure.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211310/diff/1-2/

Comment 13

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8941016 [details]
Bug 1427510 - Use current year as expiration year in credit card test case to fix perma failure.

https://reviewboard.mozilla.org/r/211310/#review217436

::: browser/extensions/formautofill/test/browser/head.js:110
(Diff revision 2)
>  
>  const TEST_CREDIT_CARD_2 = {
>    "cc-name": "Timothy Berners-Lee",
>    "cc-number": "1111222233334444",
>    "cc-exp-month": 12,
>    "cc-exp-year": 2022,

Not sure what `2022` will be used for but I think we shouldn't hardcode this number, either. Besides, I think we also need to test the upper bound of "cc-exp-year" in the dialog in Preferences.

Comment 14

[Scott Wu [:scottwu]]

Comment on attachment 8941016 [details]
Bug 1427510 - Use current year as expiration year in credit card test case to fix perma failure.

https://reviewboard.mozilla.org/r/211310/#review217436

> Not sure what `2022` will be used for but I think we shouldn't hardcode this number, either. Besides, I think we also need to test the upper bound of "cc-exp-year" in the dialog in Preferences.

Thanks for the suggestion. I changed the test case to the maximum year (+10 years), and added a test case to make sure it could be entered into the dialog.

Comment 15

[Scott Wu [:scottwu]]

Comment on attachment 8941016 [details]
Bug 1427510 - Use current year as expiration year in credit card test case to fix perma failure.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211310/diff/2-3/

Comment 16

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8941016 [details]
Bug 1427510 - Use current year as expiration year in credit card test case to fix perma failure.

https://reviewboard.mozilla.org/r/211310/#review218456

Thanks.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93fa34d5492c
Use current year as expiration year in credit card test case to fix perma failure. r=lchang

Comment 18

[Natalia Csoregi [:nataliaCs]]

Backed out for failing browser/extensions/formautofill/test/browser/browser_editCreditCardDialog.js

backout: https://hg.mozilla.org/integration/autoland/rev/9eb1b0cd2f1c281357b98418af4ed2ca04f95af2

push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=93fa34d5492cfaa900f3eb109cde76ef1c5f5917

failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=156317794&repo=autoland&lineNumber=4125

Comment 19

[Scott Wu [:scottwu]]

Comment on attachment 8941016 [details]
Bug 1427510 - Use current year as expiration year in credit card test case to fix perma failure.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211310/diff/3-4/

Comment 20

[Scott Wu [:scottwu]]

Looks fine on Try now: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5817e586a7408f91ceb085887004e1c6b166d7a0

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d6ef6b74bfa
Use current year as expiration year in credit card test case to fix perma failure. r=lchang

Comment 22

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2d6ef6b74bfa

Comment 23

[Sylvestre Ledru [:Sylvestre]]

I guess we fixed it