Closed Bug 1427525 Opened 2 years ago Closed 10 months ago

Intermittent leakcheck | tab process: 48 bytes leaked (DOMGCSliceCallback::InterSliceGCRunner, nsTArray_base)

Categories

(Core :: XPCOM, defect, P5)

Product:
Core
Component:
XPCOM
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1515216
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: smaug)

References

Details

(Keywords: intermittent-failure, memory-leak)

Attachments

(1 file)

interslice_gc_runner_leak.diff
1.60 KB, patch
mccr8
: review+
Details | Diff | Splinter Review 
Filed by: apavel [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=153617838&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/SPZ_IZ1ZTl-cMH0R_NGvjA/runs/0/artifacts/public/logs/live_backing.log

09:47:04     INFO - TEST-START | dom/indexedDB/test/test_storage_manager_estimate.html
09:47:04     INFO - GECKO(980) | ++DOMWINDOW == 7 (0x116ecfc00) [pid = 981] [serial = 7] [outer = 0x11c6793f0]
09:47:05     INFO - GECKO(980) | [Parent 980, Socket Thread] WARNING: '!workerPrivate', file /builds/worker/workspace/build/src/dom/base/nsContentUtils.cpp, line 2372
09:47:05     INFO - GECKO(980) | ++DOMWINDOW == 8 (0x116ed7000) [pid = 981] [serial = 8] [outer = 0x11c6793f0]
09:47:05     INFO - GECKO(980) | [Parent 980, Socket Thread] WARNING: '!workerPrivate', file /builds/worker/workspace/build/src/dom/base/nsContentUtils.cpp, line 2372
09:47:05     INFO - GECKO(980) | [Parent 980, Socket Thread] WARNING: '!workerPrivate', file /builds/worker/workspace/build/src/dom/base/nsContentUtils.cpp, line 2372
09:47:05     INFO - GECKO(980) | [Parent 980, Socket Thread] WARNING: '!workerPrivate', file /builds/worker/workspace/build/src/dom/base/nsContentUtils.cpp, line 2372
09:47:05     INFO - GECKO(980) | [Parent 980, Socket Thread] WARNING: '!workerPrivate', file /builds/worker/workspace/build/src/dom/base/nsContentUtils.cpp, line 2372
09:47:06     INFO - GECKO(980) | [Child 981, Main Thread] WARNING: Unable to find interface object on global: file /builds/worker/workspace/build/src/dom/base/nsDOMClassInfo.cpp, line 1746
09:47:06     INFO - GECKO(980) | [Child 981, Main Thread] WARNING: NS_ENSURE_TRUE(!(err)) failed: file /builds/worker/workspace/build/src/toolkit/xre/nsXREDirProvider.cpp, line 1422
09:47:06     INFO - GECKO(980) | [Child 981, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /builds/worker/workspace/build/src/toolkit/xre/nsXREDirProvider.cpp, line 1560
09:47:06     INFO - GECKO(980) | [Parent 980, IndexedDB #2] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80630001: file /builds/worker/workspace/build/src/storage/mozStorageConnection.cpp, line 759
09:47:06     INFO - GECKO(980) | [Parent 980, IndexedDB #2] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80630001: file /builds/worker/workspace/build/src/storage/mozStorageService.cpp, line 718
09:47:06     INFO - GECKO(980) | [Parent 980, IndexedDB #2] WARNING: Received NS_ERROR_STORAGE_BUSY when attempting to open database '1832656436%25l2mFtthe.settsa%25m2iF.sqlite', retrying for up to 10 seconds: file /builds/worker/workspace/build/src/dom/indexedDB/ActorsParent.cpp, line 4442
09:47:06     INFO - GECKO(980) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
09:47:06     INFO - GECKO(980) | MEMORY STAT | vsize 3878MB | residentFast 107MB | heapAllocated 18MB
09:47:06     INFO - TEST-OK | dom/indexedDB/test/test_storage_manager_estimate.html | took 1787ms
09:47:06     INFO - TEST-START | Shutdown
09:47:06     INFO - Passed:  11
09:47:06     INFO - Failed:  0
09:47:06     INFO - Todo:    0
09:47:06     INFO - Mode:    e10s
09:47:06     INFO - Slowest: 1787ms - /tests/dom/indexedDB/test/test_storage_manager_estimate.html
09:47:06     INFO - SimpleTest FINISHED
09:47:06     INFO - TEST-INFO | Ran 1 Loops
09:47:06     INFO - SimpleTest FINISHED
09:47:07     INFO - GECKO(980) | [Child 981, Main Thread] WARNING: nsAppShell::Exit() called redundantly: file /builds/worker/workspace/build/src/widget/cocoa/nsAppShell.mm, line 738
09:47:07     INFO - GECKO(980) | --DOCSHELL 0x11da7a000 == 3 [pid = 980] [id = {113b6ee1-a0f5-314a-a816-e2514c424dcc}]
09:47:07     INFO - GECKO(980) | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
09:47:07     INFO - GECKO(980) | [Child 981, Main Thread] WARNING: NS_ENSURE_TRUE(maybeContext) failed: file /builds/worker/workspace/build/src/xpcom/threads/nsThread.cpp, line 791
09:47:07     INFO - GECKO(980) | --DOCSHELL 0x127fb1800 == 2 [pid = 980] [id = {58cb1218-c010-154d-86b3-42071717a196}]
09:47:07     INFO - GECKO(980) | [Child 982, Main Thread] WARNING: nsAppShell::Exit() called redundantly: file /builds/worker/workspace/build/src/widget/cocoa/nsAppShell.mm, line 738
09:47:07     INFO - GECKO(980) | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
09:47:07     INFO - GECKO(980) | [Child 982, Main Thread] WARNING: NS_ENSURE_TRUE(maybeContext) failed: file /builds/worker/workspace/build/src/xpcom/threads/nsThread.cpp, line 791
09:47:07     INFO - GECKO(980) | [Child 982, Main Thread] WARNING: NS_ENSURE_TRUE(maybeContext) failed: file /builds/worker/workspace/build/src/xpcom/threads/nsThread.cpp, line 791
09:47:07     INFO - GECKO(980) | [Child 982, Main Thread] WARNING: '!gThread', file /builds/worker/workspace/build/src/xpcom/threads/nsTimerImpl.cpp, line 399
09:47:07     INFO - GECKO(980) | [Child 982, Main Thread] WARNING: '!gThread', file /builds/worker/workspace/build/src/xpcom/threads/nsTimerImpl.cpp, line 399
09:47:07     INFO - GECKO(980) | [Child 982, Main Thread] WARNING: '!gThread', file /builds/worker/workspace/build/src/xpcom/threads/nsTimerImpl.cpp, line 399
09:47:07     INFO - GECKO(980) | --DOCSHELL 0x1284ac800 == 1 [pid = 981] [id = {2bdcbe67-f50a-714e-8a40-160d8cff2622}]
09:47:07     INFO - GECKO(980) | --DOCSHELL 0x11fa7c000 == 0 [pid = 981] [id = {26497928-9a11-a148-bbfd-d09fedf0adb4}]
09:47:07     INFO - GECKO(980) | --DOMWINDOW == 7 (0x116ec9c00) [pid = 981] [serial = 6] [outer = 0x0] [url = about:blank]
09:47:07     INFO - GECKO(980) | --DOMWINDOW == 6 (0x120f4f800) [pid = 981] [serial = 2] [outer = 0x0] [url = about:blank]
09:47:07     INFO - GECKO(980) | [Child 982, Main Thread] WARNING: '!gThread', file /builds/worker/workspace/build/src/xpcom/threads/nsTimerImpl.cpp, line 399
09:47:07     INFO - GECKO(980) | nsStringStats
09:47:07     INFO - GECKO(980) |  => mAllocCount:          12283
09:47:07     INFO - GECKO(980) |  => mReallocCount:          222
09:47:07     INFO - GECKO(980) |  => mFreeCount:           12283
09:47:07     INFO - GECKO(980) |  => mShareCount:           5099
09:47:07     INFO - GECKO(980) |  => mAdoptCount:            316
09:47:07     INFO - GECKO(980) |  => mAdoptFreeCount:        316
09:47:07     INFO - GECKO(980) |  => Process ID: 982, Thread ID: 140735182725888
09:47:07     INFO - GECKO(980) | *** UTM:SVC TimerManager:registerTimer called after profile-before-change notification. Ignoring timer registration for id: telemetry_modules_ping
09:47:07     INFO - GECKO(980) | 1514656027512	Marionette	DEBUG	Received observer notification "xpcom-shutdown"
09:47:07     INFO - GECKO(980) | 1514656027513	Marionette	DEBUG	New connections will no longer be accepted
09:47:07     INFO - GECKO(980) | [Parent 980, Main Thread] WARNING: nsAppShell::Exit() called redundantly: file /builds/worker/workspace/build/src/widget/cocoa/nsAppShell.mm, line 738
09:47:07     INFO - GECKO(980) | [Parent 980, Main Thread] WARNING: NS_ENSURE_TRUE(maybeContext) failed: file /builds/worker/workspace/build/src/xpcom/threads/nsThread.cpp, line 791
09:47:07     INFO - GECKO(980) | --DOMWINDOW == 5 (0x116ed7000) [pid = 981] [serial = 8] [outer = 0x0] [url = https://example.com/tests/dom/indexedDB/test/test_storage_manager_estimate.html]
09:47:07     INFO - GECKO(980) | --DOMWINDOW == 4 (0x127a90000) [pid = 981] [serial = 3] [outer = 0x0] [url = about:blank]
09:47:07     INFO - GECKO(980) | --DOMWINDOW == 3 (0x116ecfc00) [pid = 981] [serial = 7] [outer = 0x0] [url = about:blank]
09:47:07     INFO - GECKO(980) | --DOMWINDOW == 2 (0x11c678660) [pid = 981] [serial = 1] [outer = 0x0] [url = https://example.com/tests?autorun=1&closeWhenDone=1&consoleLevel=INFO&hideResultsTable=1&manifestFile=tests.json&dumpOutputDirectory=%2Fvar%2Ffolders%2Fm9%2Fs7s6tdks6n502lphqypfc07h00000w%2FT&cleanupCrashes=true]
09:47:07     INFO - GECKO(980) | --DOMWINDOW == 1 (0x128775c00) [pid = 981] [serial = 4] [outer = 0x0] [url = https://example.com/tests?autorun=1&closeWhenDone=1&consoleLevel=INFO&hideResultsTable=1&manifestFile=tests.json&dumpOutputDirectory=%2Fvar%2Ffolders%2Fm9%2Fs7s6tdks6n502lphqypfc07h00000w%2FT&cleanupCrashes=true]
09:47:07     INFO - GECKO(980) | --DOMWINDOW == 0 (0x11c6793f0) [pid = 981] [serial = 5] [outer = 0x0] [url = https://example.com/tests/dom/indexedDB/test/test_storage_manager_estimate.html]
09:47:07     INFO - GECKO(980) | [Child 981, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 403
09:47:07     INFO - GECKO(980) | [Child 981, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 403
09:47:07     INFO - GECKO(980) | [Child 981, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 403
09:47:07     INFO - GECKO(980) | [Child 981, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 403
09:47:07     INFO - GECKO(980) | [Child 981, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 403
09:47:07     INFO - GECKO(980) | [Child 981, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 403
09:47:07     INFO - GECKO(980) | [Child 981, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 403
09:47:07     INFO - GECKO(980) | [Child 981, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 403
09:47:07     INFO - GECKO(980) | [Child 981, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/workspace/build/src/xpcom/base/nsCycleCollector.cpp, line 3686
09:47:07     INFO - GECKO(980) | nsStringStats
09:47:07     INFO - GECKO(980) |  => mAllocCount:          19950
09:47:07     INFO - GECKO(980) |  => mReallocCount:          423
09:47:07     INFO - GECKO(980) |  => mFreeCount:           19950
09:47:07     INFO - GECKO(980) |  => mShareCount:          14927
09:47:07     INFO - GECKO(980) |  => mAdoptCount:           2022
09:47:07     INFO - GECKO(980) |  => mAdoptFreeCount:       2022
09:47:07     INFO - GECKO(980) |  => Process ID: 981, Thread ID: 140735182725888
09:47:08     INFO - GECKO(980) | --DOCSHELL 0x11da94000 == 1 [pid = 980] [id = {e83d05df-9ebd-9947-bbb1-d9f6bf449328}]
09:47:08     INFO - GECKO(980) | --DOCSHELL 0x1279a8000 == 0 [pid = 980] [id = {763de50a-cad0-1a40-a878-f603d4cd5719}]
09:47:09     INFO - GECKO(980) | --DOMWINDOW == 7 (0x125ca1400) [pid = 980] [serial = 4] [outer = 0x0] [url = about:blank]
09:47:09     INFO - GECKO(980) | --DOMWINDOW == 6 (0x114025090) [pid = 980] [serial = 1] [outer = 0x0] [url = chrome://browser/content/hiddenWindow.xul]
09:47:09     INFO - GECKO(980) | --DOMWINDOW == 5 (0x11da3a800) [pid = 980] [serial = 2] [outer = 0x0] [url = about:blank]
09:47:09     INFO - GECKO(980) | --DOMWINDOW == 4 (0x129b27c00) [pid = 980] [serial = 8] [outer = 0x0] [url = about:blank]
09:47:09     INFO - GECKO(980) | --DOMWINDOW == 3 (0x127ff3800) [pid = 980] [serial = 7] [outer = 0x0] [url = about:blank]
09:47:09     INFO - GECKO(980) | --DOMWINDOW == 2 (0x127d0fc30) [pid = 980] [serial = 6] [outer = 0x0] [url = about:blank]
09:47:09     INFO - GECKO(980) | [Parent 980, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 403
09:47:09     INFO - GECKO(980) | [Parent 980, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 403
09:47:09     INFO - GECKO(980) | [Parent 980, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 403
09:47:09     INFO - GECKO(980) | [Parent 980, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 403
09:47:09     INFO - GECKO(980) | [Parent 980, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 403
09:47:09     INFO - GECKO(980) | [Parent 980, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 403
09:47:09     INFO - GECKO(980) | [Parent 980, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 403
09:47:09     INFO - GECKO(980) | [Parent 980, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 403
09:47:09     INFO - GECKO(980) | --DOMWINDOW == 1 (0x114025e20) [pid = 980] [serial = 3] [outer = 0x0] [url = chrome://browser/content/browser.xul]
09:47:09     INFO - GECKO(980) | --DOMWINDOW == 0 (0x114029650) [pid = 980] [serial = 5] [outer = 0x0] [url = about:blank]
09:47:09     INFO - GECKO(980) | nsStringStats
09:47:09     INFO - GECKO(980) |  => mAllocCount:          77929
09:47:09     INFO - GECKO(980) |  => mReallocCount:         4914
09:47:09     INFO - GECKO(980) |  => mFreeCount:           77929
09:47:09     INFO - GECKO(980) |  => mShareCount:          87362
09:47:09     INFO - GECKO(980) |  => mAdoptCount:           3772
09:47:09     INFO - GECKO(980) |  => mAdoptFreeCount:       3772
09:47:09     INFO - GECKO(980) |  => Process ID: 980, Thread ID: 140735182725888
09:47:09     INFO - TEST-INFO | Main app process: exit 0
09:47:09     INFO - runtests.py | Application ran for: 0:00:10.380269
09:47:09     INFO - zombiecheck | Reading PID log: /var/folders/m9/s7s6tdks6n502lphqypfc07h00000w/T/tmp_NSAwBpidlog
09:47:09     INFO - ==> process 980 launched child process 981
09:47:09     INFO - ==> process 980 launched child process 982
09:47:09     INFO - zombiecheck | Checking for orphan process with PID: 981
09:47:09     INFO - zombiecheck | Checking for orphan process with PID: 982
09:47:09     INFO - Stopping web server
09:47:09     INFO - Stopping web socket server
09:47:09     INFO - Stopping ssltunnel
09:47:09     INFO - TEST-INFO | leakcheck | default process: leak threshold set at 0 bytes
09:47:09     INFO - TEST-INFO | leakcheck | plugin process: leak threshold set at 0 bytes
09:47:09     INFO - TEST-INFO | leakcheck | tab process: leak threshold set at 0 bytes
09:47:09     INFO - TEST-INFO | leakcheck | geckomediaplugin process: leak threshold set at 20000 bytes
09:47:09     INFO - TEST-INFO | leakcheck | gpu process: leak threshold set at 0 bytes
09:47:09     INFO - 
09:47:09     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, default process 980
09:47:09     INFO - 
09:47:09     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
09:47:09     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
09:47:09     INFO -    0 |TOTAL                                 |       32        0| 1092532        0|
09:47:09     INFO - 
09:47:09     INFO - nsTraceRefcnt::DumpStatistics: 1798 entries
09:47:09     INFO - 
09:47:09     INFO - TEST-PASS | leakcheck | default process: no leaks detected!
09:47:09     INFO - 
09:47:09     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, tab process 977
09:47:09     INFO - 
09:47:09     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
09:47:09     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
09:47:09     INFO -    0 |TOTAL                                 |       34       48| 7847133        2|
09:47:09     INFO -   97 |DOMGCSliceCallback::InterSliceGCRunner|       40       40|     561        1|
09:47:09     INFO - 1202 |nsTArray_base                         |        8        8| 2710003        1|
09:47:09     INFO - 
09:47:09     INFO - nsTraceRefcnt::DumpStatistics: 1281 entries
09:47:09     INFO - TEST-INFO | leakcheck | tab process: leaked 1 DOMGCSliceCallback::InterSliceGCRunner
09:47:09     INFO - TEST-INFO | leakcheck | tab process: leaked 1 nsTArray_base
09:47:09    ERROR - TEST-UNEXPECTED-FAIL | leakcheck | tab process: 48 bytes leaked (DOMGCSliceCallback::InterSliceGCRunner, nsTArray_base)
Component: DOM: IndexedDB → XPCOM
See Also: → 1416927
Interesting.
Don't immediately see how this is possible though.
Oh, yes I do.
Assignee: nobody → bugs
I'm pretty sure this is about sPendingIdleRunnables in nsRefreshDriver
Be more consistent with shutdown handling and killing runners.
This is a bit guess fix.
Attachment #8940014 - Flags: review?(continuation)
Comment on attachment 8940014 [details] [diff] [review]
interslice_gc_runner_leak.diff

Review of attachment 8940014 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for taking a look.
Attachment #8940014 - Flags: review?(continuation) → review+
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8861cbed426
try to not leak IdleTaskRunners related to GC/CC during shutdow, r=mccr8
https://hg.mozilla.org/mozilla-central/rev/e8861cbed426
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
This has happened since Olli's patch landed, so I guess it isn't fixed. This seems quite rare, though.
See Also: → 1431286
See Also: → 1442575
Looks like the signature for these leaks changed a little, presumably due to some of the work related to WPT.
Status: REOPENED → RESOLVED
Closed: 2 years ago → 10 months ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1515216
You need to log in before you can comment on or make changes to this bug.