Closed
Bug 1427645
Opened 6 years ago
Closed 6 years ago
As follow-up to bug 1427124 and bug 1259534, check how well body search works if multipart messages have quoted-printable parts
Categories
(MailNews Core :: Search, enhancement)
MailNews Core
Search
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 59.0
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
Details
Attachments
(1 file, 2 obsolete files)
|
18.55 KB,
patch
|
aceman
:
review+
|
Details | Diff | Splinter Review |
We should add the same set of 10 tests with quoted-printable messages to see what works and fix what doesn't work.
|
Assignee | |
Updated•6 years ago
|
Version: 52 → Trunk
|
|
Assignee | |
Comment 1•6 years ago
|
||
Since I fixed returning the correct charset in bug 1427124, QP encoded stuff works already and the 10 tests added here prove it. I changed the Greek from "good evening" to "good morning" and the German umlaute to ä and ö, otherwise it's the same set of tests.
Attachment #8939431 -
Flags: review?(acelists)
|
|
Assignee | |
Comment 2•6 years ago
|
||
Sorry about the noise, I decided to use quoted charsets here to test the follow-up patch from bug 1427124.
Attachment #8939431 -
Attachment is obsolete: true
Attachment #8939431 -
Flags: review?(acelists)
Attachment #8939432 -
Flags: review?(acelists)
|
|
Assignee | |
Comment 3•6 years ago
|
||
Grrr, find and replace added too many quotes now :-(
Attachment #8939432 -
Attachment is obsolete: true
Attachment #8939432 -
Flags: review?(acelists)
Attachment #8939434 -
Flags: review?(acelists)
Comment on attachment 8939434 [details] [diff] [review] 1427645-non-ascii-body-search-QP.patch (v3) Review of attachment 8939434 [details] [diff] [review]: ----------------------------------------------------------------- Thanks a lot.
Attachment #8939434 -
Flags: review?(acelists) → review+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/96593a2f19ef add 10 tests for body search for non-ASCII bodies encoded in quoted-printable. r=aceman
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 59.0
|
|
Assignee | |
Comment 6•6 years ago
|
||
TB 52.7 ESR https://hg.mozilla.org/releases/comm-esr52/rev/3ff5caaa5a5851d6a49bd4bac1935511f89e197e Needed to uplift this since otherwise bug 1434020 couldn't have been uplifted.
You need to log in
before you can comment on or make changes to this bug.
Description
•